OSX with CEF3 and OnFileDialog

[schetle]

I'm implementing the CefDialogHandler, and have a custom OnFileDialog.

My only question is - why is the browser object passed to OnFileDialog NULL? I need the browser object to get the window handle to properly display an NSOpenPanel in the proper window, but can't access the browser object.

I'm doing nothing out of the ordinary that I know of.

Thanks!

Code: Select all


/* MyHandler.h */

class MyHandler : public CefDialogHandler
...

virtual CefRefPtr<CefDialogHandler> GetDialogHandler() OVERRIDE {
return this;
}

virtual bool OnFileDialog(CefRefPtr<CefBrowser> browser,
                          FileDialogMode mode,
                          const CefString& title,
                          const CefString& default_file_name,
                          const std::vector<CefString>& accept_types,
                          CefRefPtr<CefFileDialogCallback> callback) OVERRIDE;


Code: Select all


/* MyHandler.mm */

bool MyHandler::OnFileDialog(CefRefPtr<CefBrowser> browser,
                          FileDialogMode mode,
                          const CefString& title,
                          const CefString& default_file_name,
                          const std::vector<CefString>& accept_types,
                                        CefRefPtr<CefFileDialogCallback> callback) {
   
   
    /*

        NSWindow *browserWindow = [browser.get()->GetHost()->GetWindowHandle() window]; // EXC_BAD_ACCESS, browser ptr_ = NULL

        NSWindow *browserWindow = [browser->GetHost()->GetWindowHandle() window]; // EXC_BAD_ACCESS, browser ptr_ = NULL

    */


    ...


[fernandomorgan]

You can implement

FileDlg(std::vector<CefString>& file_paths, FileDialogMode mode, const CefString& title, const CefString& default_file_name, const std::vector<CefString>& accept_types)

and then call the native NSOpenPanel, etc,

[schetle]

Is that something I need to override from Chromium? I don't see a reference to that anywhere in the CEF3 code.

Is there a reason why the browser object is null that I'm missing?

I wouldn't bother with the native NSOpenPanel, if the default File Dialog wouldn't spinning-wheel crash the app when the file dialog is canceled while AppStore sandboxing is turned on. Instruments shows that it's endlessly trying to access things it shouldn't, when cancelled. But that's a different question for a different thread.

[magreenblatt]

why is the browser object passed to OnFileDialog NULL?

How are you triggering the file dialog?

[schetle]

The file dialog was being triggered by any file input from standard websites.