Failing to build dev branch (2171)

[starkos]

I'm trying to get a source build of CEF working with the intention of making some contributions to the project. Following along with the instructions on the "Branches and Building" wiki page, I've tried to build the latest dev branch, and the automate-git.py script is failing with output below.

I'm going to try building against trunk instead (I thought the dev branch might give me a little more stability, since I'm also developing a CEF-based app that I would like to get shipped soon); perhaps this has already been fixed there.

Update: Same issue with trunk (running `python automate-git.py --download-dir=.`)

Code: Select all

# ... bunch of output snipped ...

Patching build configuration and source files for CEF...

________ running '/usr/bin/python tools/patcher.py --patch-config patch/patch.cfg' in '/Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef'
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/gritsettings.patch
WARNING:root:successfully patched ../tools/gritsettings/resource_ids
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/build.patch
WARNING:root:successfully patched ../build/common.gypi
WARNING:root:successfully patched ../build/gyp_chromium
WARNING:root:successfully patched ../build/mac/strip_save_dsym
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/zlib.patch
WARNING:root:successfully patched ../third_party/zlib/contrib/minizip/unzip.c
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/message_loop_443.patch
WARNING:root:successfully patched ../base/message_loop/message_loop.cc
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/gyp_331.patch
WARNING:root:successfully patched ../tools/gyp/pylib/gyp/generator/ninja.py
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/webkit_popups.patch
WARNING:root:successfully patched ../third_party/WebKit/Source/web/ChromeClientImpl.cpp
WARNING:root:successfully patched ../third_party/WebKit/Source/web/WebViewImpl.cpp
WARNING:root:successfully patched ../third_party/WebKit/Source/web/WebViewImpl.h
WARNING:root:successfully patched ../third_party/WebKit/public/web/WebView.h
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/underlay_1051.patch
WARNING:root:successfully patched ../ui/base/cocoa/underlay_opengl_hosting_window.h
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/views_widget_180.patch
WARNING:root:successfully patched ../ui/views/widget/desktop_aura/desktop_screen_win.cc
WARNING:root:successfully patched ../ui/views/widget/desktop_aura/desktop_screen_x11.cc
WARNING:root:successfully patched ../ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
WARNING:root:successfully patched ../ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
WARNING:root:successfully patched ../ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
WARNING:root:successfully patched ../ui/views/widget/widget.cc
WARNING:root:successfully patched ../ui/views/widget/widget.h
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/content_nav_1129.patch
WARNING:root:successfully patched ../content/public/renderer/content_renderer_client.cc
WARNING:root:successfully patched ../content/public/renderer/content_renderer_client.h
WARNING:root:successfully patched ../content/renderer/render_frame_impl.cc
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/browser_1161.patch
WARNING:root:successfully patched ../content/browser/compositor/io_surface_layer_mac.mm
WARNING:root:successfully patched ../content/browser/renderer_host/compositing_iosurface_mac.mm
WARNING:root:successfully patched ../content/browser/renderer_host/render_widget_host_view_aura.cc
WARNING:root:successfully patched ../content/browser/renderer_host/render_widget_host_view_mac.mm
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/public_browser_1161_1257.patch
WARNING:root:successfully patched ../content/public/browser/content_browser_client.cc
WARNING:root:successfully patched ../content/public/browser/content_browser_client.h
WARNING:root:successfully patched ../content/public/browser/web_contents.cc
WARNING:root:successfully patched ../content/public/browser/web_contents.h
WARNING:root:successfully patched ../content/public/browser/web_contents_delegate.cc
WARNING:root:successfully patched ../content/public/browser/web_contents_delegate.h
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/browser_web_contents_1257.patch
WARNING:root:successfully patched ../content/browser/web_contents/web_contents_impl.cc
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/prefs_content_1161.patch
WARNING:root:successfully patched ../content/public/common/common_param_traits_macros.h
WARNING:root:successfully patched ../content/public/common/web_preferences.cc
WARNING:root:successfully patched ../content/public/common/web_preferences.h
WARNING:root:successfully patched ../content/renderer/render_view_impl.cc
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/webkit_platform_mac_328814.patch
WARNING:root:successfully patched ../third_party/WebKit/Source/platform/mac/ThemeMac.mm
WARNING:root:successfully patched ../third_party/WebKit/Source/platform/mac/WebCoreNSCellExtras.h
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/ui_dragdrop_355390.patch
WARNING:root:successfully patched ../ui/base/dragdrop/os_exchange_data_provider_aurax11.cc
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/printing_win.patch
WARNING:root:successfully patched ../chrome/common/chrome_utility_printing_messages.h
WARNING:root:successfully patched ../content/renderer/pepper/pepper_plugin_instance_impl.cc
Reading patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/spellcheck_137.patch
WARNING:root:successfully patched ../chrome/browser/spellchecker/spellcheck_factory.cc
WARNING:root:successfully patched ../chrome/browser/spellchecker/spellcheck_factory.h
Skipping patch file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patches/spi_webcore_364.patch
Writing file /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef/patch/patch_state.h.

Generating CEF project files...

________ running '/usr/bin/python ../build/gyp_chromium cef.gyp -I cef.gypi' in '/Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef'
Updating projects from gyp files...
--> Writing file: /Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/out/cef.branch
-------- Running "ninja -C out/Debug cefclient" in "/Users/Jason/Code/Musicality/Musicality-CEF/chromium/src"...
ninja: Entering directory `out/Debug'
ninja: error: '../../chrome/browser/ui/cocoa/nsview_additions.mm', needed by 'obj/chrome/browser/ui/cocoa/libcef_static.nsview_additions.o', missing and no known rule to make it
Traceback (most recent call last):
  File "automate-git.py", line 898, in <module>
    if options.buildlogfile else None)
  File "automate-git.py", line 74, in run
    shell=(sys.platform == 'win32'))
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['ninja', '-C', 'out/Debug', 'cefclient']' returned non-zero exit status 1


[magreenblatt]

Thanks for the report. Fixed in trunk revision 1872 and 2171 branch revision 1873.

[starkos]

My apologies, I should have opened a ticket for this. I hope you don't mind me continuing the thread; let me know and I will create an issue for you.

I did get farther this time, now failing with this on branch 2171; will try on trunk:

Code: Select all

Generating CEF project files...

________ running '/usr/bin/python ../build/gyp_chromium cef.gyp -I cef.gypi' in '/Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/cef'
Updating projects from gyp files...
-------- Running "ninja -C out/Debug cefclient" in "/Users/Jason/Code/Musicality/Musicality-CEF/chromium/src"...
ninja: Entering directory `out/Debug'
[6135/12020] ACTION cef_pak: make_pack_resources_header_a1c8707ee8a92f0d9bb2b14b0314186d
File include/cef_pack_resources.h updated.
[6137/12020] ACTION cef_pak: make_pack_strings_header_a1c8707ee8a92f0d9bb2b14b0314186d
File include/cef_pack_strings.h updated.
[12020/12020] STAMP cefclient.app
-------- Running "ninja -C out/Release cefclient" in "/Users/Jason/Code/Musicality/Musicality-CEF/chromium/src"...
ninja: Entering directory `out/Release'
[1717/12020] ACTION cef_locales: repack_locales_a2bf821e5a2b16c02628490a6fe9cb4b
FAILED: cd ../../cef; export BUILT_PRODUCTS_DIR=/Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/out/Release; export CONFIGURATION=Release; export PRODUCT_NAME=cef_locales; export SDKROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk; export SRCROOT=/Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/out/Release/../../cef; export SOURCE_ROOT="${SRCROOT}"; export TARGET_BUILD_DIR=/Users/Jason/Code/Musicality/Musicality-CEF/chromium/src/out/Release; export TEMP_DIR="${TMPDIR}";python tools/repack_locales.py -g ../out/Release/gen/cef -s ../out/Release/gen -x ../out/Release/locales am ar bg bn ca cs da de el en-GB en-US es-419 es et fa fi fil fr gu he hi hr hu id it ja kn ko lt lv ml mr ms nb nl pl pt-BR pt-PT ro ru sk sl sr sv sw ta te th tr uk vi zh-CN zh-TW
Traceback (most recent call last):
  File "tools/repack_locales.py", line 184, in <module>
    results = DoMain(sys.argv[1:])
  File "tools/repack_locales.py", line 181, in DoMain
    return repack_locales(locales)
  File "tools/repack_locales.py", line 116, in repack_locales
    data_pack.DataPack.RePack(output, inputs)
  File "tools/../../tools/grit/grit/format/data_pack.py", line 126, in RePack
    input_data_packs = [ReadDataPack(filename) for filename in input_files]
  File "tools/../../tools/grit/grit/format/data_pack.py", line 53, in ReadDataPack
    data = util.ReadFile(input_file, util.BINARY)
  File "tools/../../tools/grit/grit/util.py", line 207, in ReadFile
    with open(filename, mode) as f:
IOError: [Errno 2] No such file or directory: '../out/Release/gen/components/strings/components_strings_am.pak'
[1717/12020] CXX obj/third_party/pdfium/core/src/fpdfapi/fpdf_font/fpdfapi.fpdf_font.o
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
  File "automate-git.py", line 905, in <module>
    if options.buildlogfile else None)
  File "automate-git.py", line 74, in run
    shell=(sys.platform == 'win32'))
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['ninja', '-C', 'out/Release', 'cefclient']' returned non-zero exit status 1


[magreenblatt]

What OS are you using? Did you update to revision 1873 and re-run cef_create_projects.sh? Did you try a clean build?

[starkos]

I'm on OS X 10.10 Xcode 6, which could definitely be part of the issue. I am able to build Chromium's content_shell target, on 39.0.2171.24. I'm poking around the scripts and gyp files and seeing if I can figure this out myself. In case it is a legitimate issue...

I just re-ran `automate-git.py --download-dir=. --branch=2171` from the same working folder. It looks like I'm on revision 1875:

Code: Select all

cef_2171:Jason$ git log
commit 6c74ffe096eb47421a27b556adcf11847252e013
Author: Marshall Greenblatt <magreenblatt@gmail.com>
Date:   Tue Oct 14 17:57:35 2014 +0000

    Fix type conversion compile error (issue #1397).
   
    git-svn-id: https://chromiumembedded.googlecode.com/svn/branches/2171/cef3@1875 5089003a-bbd8-11dd-ad1f-f1f9622dbc98


If I run ./cef_create_projects.sh in cef_2171 I get:

Code: Select all

cef_2171:Jason$ ./cef_create_projects.sh

Checking CEF and Chromium revisions...

________ running '/usr/bin/python tools/check_revision.py' in '/Users/Jason/Code/Musicality/Musicality-CEF/cef_2171'
Not an SVN checkout.

Generating CEF version header file...

________ running '/usr/bin/python tools/make_version_header.py --header include/cef_version.h --cef_version VERSION --chrome_version ../chrome/VERSION --cpp_header_dir include' in '/Users/Jason/Code/Musicality/Musicality-CEF/cef_2171'
Traceback (most recent call last):
  File "tools/make_version_header.py", line 171, in <module>
    written = write_svn_header(options.header, options.chrome_version, options.cef_version, options.cpp_header_dir)
  File "tools/make_version_header.py", line 48, in write_svn_header
    raise Exception('Chrome version file '+chrome_version+' does not exist.')
Exception: Chrome version file ../chrome/VERSION does not exist.
Traceback (most recent call last):
  File "tools/gclient_hook.py", line 22, in <module>
    RunAction(cef_dir, gyper)
  File "/Users/Jason/Code/Musicality/Musicality-CEF/cef_2171/tools/gclient_util.py", line 39, in RunAction
    command, cwd=dir, always=True)
  File "/Users/Jason/Code/Musicality/Musicality-CEF/depot_tools/gclient_utils.py", line 286, in CheckCallAndFilterAndHeader
    return CheckCallAndFilter(args, **kwargs)
  File "/Users/Jason/Code/Musicality/Musicality-CEF/depot_tools/gclient_utils.py", line 531, in CheckCallAndFilter
    rv, args, kwargs.get('cwd', None), None, None)
subprocess2.CalledProcessError: Command /usr/bin/python tools/make_version_header.py --header include/cef_version.h --cef_version VERSION --chrome_version ../chrome/VERSION --cpp_header_dir include returned non-zero exit status 1 in /Users/Jason/Code/Musicality/Musicality-CEF/cef_2171


[magreenblatt]

Run cef_create_projects.sh from the chromium/src/cef directory, and then "ninja -C out/Debug cefclient" from the chromium/src directory.

[starkos]

While I was waiting I blew away the cef_2171 directory and reran automate-git and this time it built successfully, so I'm good to go. Thanks for the help!