Setting to suppress Shift+Enter opening a new window?

[jholt]

Is there a way to stop Chromium from opening a new window on a Shift+Enter?

I tried grabbing it in OnPreKeyEvent, but the window seems to be opened already by the time it gets here.

I've seen some JS fragments (e.g. https://gist.github.com/jataro/2799464 ) for suppressing it (apparently neither FF nor IE have this behavior), but I'd like to suppress the behavior everywhere, so am hoping I can suppress it on the CEF/Chromium/C++ side.

[magreenblatt]

Does it call OnBeforePopup or OnOpenURLFromTab?

[grossag]

I accidentally noticed this issue and also want to suppress this behavior because I want to restrict my application to being a single-tab process. Unfortunately I do not get any callbacks to OnBeforePopup or OnOpenURLFromTab. Do you want me to file this as an issue for better tracking? If you have ideas for how to fix it, I am happy to submit a pull request with a fix.

[magreenblatt]

Unfortunately I do not get any callbacks to OnBeforePopup or OnOpenURLFromTab.

Please test this in cefclient. I believe you will see callbacks to one of these methods.

[amaitland]

Quick test using 3.2526.1362.g26b3a7a

OnOpenUrlFromTab is called for me as expected

[grossag]

Ok thanks. I had an older signature of OnBeforePopup that wasn't properly overriding the function. I updated it and now see OnBeforePopup called and can suppress it there.

[magreenblatt]

Ok thanks. I had an older signature of OnBeforePopup that wasn't properly overriding the function. I updated it and now see OnBeforePopup called and can suppress it there.

You should use the override keyword to avoid these types of errors.