Windowless popup creates win (OnBeforePopup not called)

[romariorios]

Hello.

In my application, I overrode OnBeforePopup so that all new popups became windowless:

Code: Select all

bool SimpleHandler::OnBeforePopup(
  CefRefPtr<CefBrowser> browser,
  CefRefPtr<CefFrame>,
  const CefString &,
  const CefString &,
  CefLifeSpanHandler::WindowOpenDisposition,
  bool,
  const CefPopupFeatures &,
  CefWindowInfo &winInfo,
  CefRefPtr<CefClient> &,
  CefBrowserSettings &,
  bool *)
{
  winInfo.SetAsWindowless(browser->GetHost()->GetWindowHandle(), false);

  return false;
}


However, there are some cases where a popup window still shows up. This page(EDIT: no longer available, archive version down in the replies), for example (careful, scam). If you click it soon enough, a new window shows up, apparently as a result of an event listener, listening to mousedown and touchstart on document. Any idea why this happens?

[amaitland]

Is `OnBeforePopup` being called for your scam page?

Typically I'd return true to cancel loading a popup, not just try and make them hidden.

[romariorios]

Is `OnBeforePopup` being called for your scam page?

It seems it isn't. Only OnAfterCreated is being called when that happens.

This is weird. If I click the "How to use this faucet?" text before the page loads, OnBeforePopup isn't called and the popup window shows up. But, if I wait long enough (something like 5-10 secs), OnBeforePopup gets called properly and the window gets hidden. Any idea why this happens?

EDIT: By the way, the above applies regardless of me returning true or false from OnBeforePopup.

[romariorios]

Can I bump this up? It's been a month and I still have this problem.

[Czarek]

Can you reproduce issue in cefclient? Basic info like OS/CEF versions are missing.

[romariorios]

Can you reproduce issue in cefclient? Basic info like OS/CEF versions are missing.

I'll try to reproduce it. The issue was noticed in Windows 10, CEF 2623.

[amaitland]

2623 is no longer supported, best to use 2785

[romariorios]

2623 is no longer supported, best to use 2785

How can I check that the cause for this is fixed in the latest version (currently 2840)?

[romariorios]

The page is currently offline (probably due to abuse). I still have it archived here, if anyone wants to test this: https://www.dropbox.com/s/ebmh92abykjzxgs/bluebtc.zip