[SOLVED] Need help with CefV8Context::Eval()

[Czarek]

I think you can accomplish the same using ExecuteJavascript to inject custom js on pages in CefLoadHandler and javascript bindings to communicate with C++ (see wiki pages for tutorial).

EDIT: to inject custom js from the Renderer process call CefV8Context::GetFrame::ExecuteJavascript.

[amaitland]

Interesting that CSP only appears to be limiting Eval. I would have ExecuteJavascript to behave the same, and yet it doesn't. Thank Czarek!

[Czarek]

Try also CefV8Context::GetGlobal::GetValue("pageYOffset").GetIntValue - along with HasValue and other checks.

[fasecero]

Interesting that CSP only appears to be limiting Eval. I would have ExecuteJavascript to behave the same, and yet it doesn't. Thank Czarek!

I thought exactly the same... so I even didn't try. Test below works fine on pages with CSP:

Code: Select all

FocusedFrame->ExecuteJavaScript("alert(window.pageYOffset);", FocusedFrame->GetURL(), 0);

I'll have to find a way to replace each Eval() with ExecuteJavaScript()

Code: Select all

v8Context->Eval("document.body.clientHeight", ret, excep);
v8Context->Eval("window.getSelection().toString()", ret, excep);
v8Context->Eval("document.activeElement.tagName", ret, excep);
....

I think you can accomplish the same using ExecuteJavascript to inject custom js on pages in CefLoadHandler and javascript bindings to communicate with C++ (see wiki pages for tutorial).

EDIT: to inject custom js from the Renderer process call CefV8Context::GetFrame::ExecuteJavascript.

Try also CefV8Context::GetGlobal::GetValue("pageYOffset").GetIntValue - along with HasValue and other checks.

will study how this works in detail and then try to implement a solution. I just want to thank you very much for all the help you gave me.

[fasecero]

Problem solved, one last question, do I have to somehow delete the attached values to a frame's window object?

Code: Select all

class MyApp : public CefApp,
              public CefBrowserProcessHandler,
              public CefRenderProcessHandler {

  virtual void OnContextCreated(CefRefPtr<CefBrowser> browser,
                                CefRefPtr<CefFrame> frame,
                                CefRefPtr<CefV8Context> context) OVERRIDE {

     if (frame->IsMain()) {
        CefRefPtr<CefV8Value> object = context->GetGlobal();

        CefRefPtr<CefV8Value> V8Value = CefV8Value::CreateDouble(0);
        object->SetValue("fs_pageYOffset", V8Value, V8_PROPERTY_ATTRIBUTE_NONE);

        // do I have to explicitly delete V8Value, inside OnContextReleased maybe?
     }
  }
}

[magreenblatt]

do I have to explicitly delete V8Value, inside OnContextReleased maybe?

No. The values are reference counted and will be deleted when no longer referenced.

[fasecero]

Thank you again and best regards