Changes to local CEF fails to create project

[magreenblatt]

Whenever you get a gclient sync error that references a particular third-party directory it's usually easiest just to delete that directory manually and then try again.

[sam007]

Whenever you get a gclient sync error that references a particular third-party directory it's usually easiest just to delete that directory manually and then try again.

After deleting the directory, I got it to run but it ended with an error and warning. I then did checkout of CEF to 2704 branch and ran the

Code: Select all

ninja -C out\Debug cefclient cefsimple cef_unittests

and it ran fine.

Is that alright? Can I now make the changes manually to the CEF branch for support of Certificate dialogs from the PR.

[magreenblatt]

If it built successfully then you should be fine from a build perspective.

[sam007]

If it built successfully then you should be fine from a build perspective.

What is the best way to debug CEF? I made the changes from the PR and ran create project bat file and then ran the ninja build but the result is the same. Want to make sure that the new changes were indeed taken in.

[magreenblatt]

If it built successfully then you should be fine from a build perspective.

What is the best way to debug CEF? I made the changes from the PR and ran create project bat file and then ran the ninja build but the result is the same. Want to make sure that the new changes were indeed taken in.

viewtopic.php?f=6&t=10567 #19

[sam007]

Ok, so the changes that I made compiled correctly but I wanted to confirm if "chromium_git/chromium/src/out/Debug/cefclient.exe" will reflect the changes that I made for CEF ("chromium_git/chromium/src/cef/")

This is because cefclient.exe continues to show the same outcome as before as if the changes did not affect it. So just want to know if cefclient.exe should reflect the changes made in CEF or do I need to use some other mechanism?

[magreenblatt]

Did you build the cefclient target with ninja?

ninja -C out\Debug cefclient

[sam007]

Did you build the cefclient target with ninja?

ninja -C out\Debug cefclient

Yes, I ran

Code: Select all

ninja -C out\Debug cefclient cefsimple cef_unittests