OnBrowserDestroyed never called

[magreenblatt]

from the point of view of having a clean API, OnBrowserDestroyed should always be called even if the renderer process is being terminated.

It is an intentional design choice in Chromium. Therefore what you're requesting will not happen.

For instance, if I was to allocate some system-wide resource that's not automatically freed, say a pipe or global memory, then I would have a hard time finding a good place where to free it.

Don't do that from the renderer process.

[Czarek]

from the point of view of having a clean API, OnBrowserDestroyed should always be called even if the renderer process is being terminated.

It is an intentional design choice in Chromium. Therefore what you're requesting will not happen.

For instance, if I was to allocate some system-wide resource that's not automatically freed, say a pipe or global memory, then I would have a hard time finding a good place where to free it.

Don't do that from the renderer process.

It would be nice to have this stated in doc comments.

[magreenblatt]

from the point of view of having a clean API, OnBrowserDestroyed should always be called even if the renderer process is being terminated.

It is an intentional design choice in Chromium. Therefore what you're requesting will not happen.

For instance, if I was to allocate some system-wide resource that's not automatically freed, say a pipe or global memory, then I would have a hard time finding a good place where to free it.

Don't do that from the renderer process.

It would be nice to have this stated in doc comments.

Sure Feel free to file a bug and/or submit a PR.

[Czarek]

It would be nice to have this stated in doc comments.

Sure Feel free to file a bug and/or submit a PR.

While on it, how about removing the OnBrowserDestroyed callback from the renderer process? What's the point of having it if we can't rely on it being called.

[magreenblatt]

It would be nice to have this stated in doc comments.

Sure Feel free to file a bug and/or submit a PR.

While on it, how about removing the OnBrowserDestroyed callback from the renderer process? What's the point of having it if we can't rely on it being called.

The same renderer process can be used for multiple browsers in certain circumstances. The OnBrowserDestroyed callback is useful for cleaning up state in that case.