python automate/automate-git.py --download-dir=/home/ubuntu/code/chromium_git --branch=3029 --force-build --x64-build --no-debug-build
Building on ubuntu 14.04
aws_instance.cef-build (remote-exec): [27110/27111] SOLINK ./libcef.so
aws_instance.cef-build (remote-exec): FAILED: libcef.so libcef.so.TOC
aws_instance.cef-build (remote-exec): python "/home/ubuntu/code/chromium_git/chromium/src/build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --sofile="./libcef.so" --tocfile="./libcef.so.TOC" --output="./libcef.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--no-as-needed -lpthread -Wl,--as-needed -fuse-ld=gold -B../../third_party/binutils/Linux_x64/Release/bin -Wl,--threads -Wl,--thread-count=4 -Wl,--icf=all -m64 -pthread -Werror -Wl,--export-dynamic -Wl,-uhb_ft_face_create_cached,-uhb_glib_get_unicode_funcs -o "./libcef.so" -Wl,-soname="libcef.so" @"./libcef.so.rsp"
aws_instance.cef-build (remote-exec): ../../chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_controller.cc:77: error: undefined reference to 'safe_browsing::SettingsResetPromptController::ShowSettingsResetPrompt(Browser*, safe_browsing::SettingsResetPromptController*)'
aws_instance.cef-build (remote-exec): clang: error: linker command failed with exit code 1 (use -v to see invocation)
aws_instance.cef-build (remote-exec): ninja: build stopped: subcommand failed.
aws_instance.cef-build (remote-exec): Traceback (most recent call last):
aws_instance.cef-build (remote-exec): File "automate/automate-git.py", line 980, in <module>
aws_instance.cef-build (remote-exec): if options.buildlogfile else None)
aws_instance.cef-build (remote-exec): File "automate/automate-git.py", line 55, in run
aws_instance.cef-build (remote-exec): shell=(sys.platform == 'win32'))
aws_instance.cef-build (remote-exec): File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
aws_instance.cef-build (remote-exec): raise CalledProcessError(retcode, cmd)
aws_instance.cef-build (remote-exec): subprocess.CalledProcessError: Command '['ninja', '-C', 'out/Debug_GN_x64', 'cefclient', 'chrome_sandbox']' returned non-zero exit status 1
I've done some digging and found this recent change: https://codereview.chromium.org/2701313002
What's causing the error, I think, is that settings_reset_prompt_controller.cc references settings_reset_prompt_dialog.cc, specifically SettingsResetPromptController::ShowSettingsResetPrompt (why that's defined in a different src file, I'll never know), but the problem is, settings_reset_prompt_dialog.cc in chrome/browser/ui/BUILD.gn, but only for windows: if (is_win) ...
it's a mystery to me how the builds for the above patchset passed with this configuration, it seems like it wouldn't be possible.
In any case, what's the fix for this?
Thanks!
Brice