Can't build branch 3029 (automate-git.py). Problems on skia

[edgardog]

I've been trying to make a build for days (I used to be able to make them with no problems) and I keep bumping into this issue.
Now I created a clean build environment (schroot trusty 64 clean), installed the install-build-deps.sh, them ran:

python automate-git.py --download-dir=/home/edgardog/chroot/chrome3029/code/ --branch=3029 --x64-build

and got this error:

Code: Select all


src/third_party/skia (ERROR)
----------------------------------------
[0:00:06] Started.
_____ src/third_party/skia at 4c81ba6ba3a3270db809bf7d4c3bc782694a56a4
----------------------------------------
Traceback (most recent call last):
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 2295, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 2281, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 2030, in CMDsync
    ret = client.RunOnDeps('update', args)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 1340, in RunOnDeps
    work_queue.flush(revision_overrides, command, args, options=self._options)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient_utils.py", line 1047, in run
    self.item.run(*self.args, **self.kwargs)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 766, in run
    self.ParseDepsFile()
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 562, in ParseDepsFile
    gclient_eval.Check(deps_content, filepath, global_scope, local_scope)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient_eval.py", line 240, in Check
    result_scope = _gclient_exec(content, global_scope, filename=path)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient_eval.py", line 185, in _gclient_exec
    _visit_in_module(stmt)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient_eval.py", line 181, in _visit_in_module
    getattr(node, 'lineno', '<unknown>')))
ValueError: unexpected AST node: <_ast.Import object at 0x7f306f54fc50> Import(names=[alias(name='os', asname=None)]) (file u'/home/edgardog/chroot/chrome3029/code/chromium/src/third_party/skia/DEPS', line 53)
Traceback (most recent call last):
  File "automate-git.py", line 967, in <module>
    chromium_dir, depot_tools_dir)
  File "automate-git.py", line 55, in run
    args, cwd=working_dir, env=env, shell=(sys.platform == 'win32'))
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['gclient', 'sync', '--with_branch_heads', '--jobs', '16']' returned non-zero exit status 1


Seems like something is wrong with that skia DEPS file. There are no other errors that I can see printed before.
I'm basically following: https://bitbucket.org/chromiumembedded/ ... uilding.md
I don't think I'm doing something wrong and I've done this several times before and never ran into this issue. I've use the schroot environment to cross compile for 32 bits before and also to build a 64 bit build (2987) a couple of months ago, and did not have any problems.

Any help would be appreciated.
Thanks

[magreenblatt]

Try adding the `--force-clean` flag to your automate-git.py command line.

[edgardog]

Did not help.
Adding the --force-clean resulted also in:

Code: Select all

-------- Running "gclient sync --reset --with_branch_heads --jobs 16" in "/home/edgardog/chroot/chrome3029/code/chromium"...
Syncing projects: 100% (84/84) src/v8                                                     

src/third_party/skia (ERROR)
----------------------------------------
[0:00:06] Started.
[0:00:12] From https://skia.googlesource.com/skia
[0:00:12]    8bf1f9f..2f4ddf6  master     -> origin/master
_____ src/third_party/skia at 4c81ba6ba3a3270db809bf7d4c3bc782694a56a4
----------------------------------------
Traceback (most recent call last):
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 2295, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 2281, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 2030, in CMDsync
    ret = client.RunOnDeps('update', args)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 1340, in RunOnDeps
    work_queue.flush(revision_overrides, command, args, options=self._options)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient_utils.py", line 1047, in run
    self.item.run(*self.args, **self.kwargs)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 766, in run
    self.ParseDepsFile()
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 562, in ParseDepsFile
    gclient_eval.Check(deps_content, filepath, global_scope, local_scope)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient_eval.py", line 242, in Check
    result_scope = _gclient_exec(content, global_scope, filename=path)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient_eval.py", line 187, in _gclient_exec
    _visit_in_module(stmt)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient_eval.py", line 183, in _visit_in_module
    getattr(node, 'lineno', '<unknown>')))
ValueError: unexpected AST node: <_ast.Import object at 0x7f2b6eddf790> Import(names=[alias(name='os', asname=None)]) (file u'/home/edgardog/chroot/chrome3029/code/chromium/src/third_party/skia/DEPS', line 53)
Traceback (most recent call last):
  File "automate-git.py", line 967, in <module>
    chromium_dir, depot_tools_dir)
  File "automate-git.py", line 55, in run
    args, cwd=working_dir, env=env, shell=(sys.platform == 'win32'))
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['gclient', 'sync', '--reset', '--with_branch_heads', '--jobs', '16']' returned non-zero exit status 1


I'm setting up a clean ubuntu14 computer just to discard problems with schroot, but I honestly don't think that could be the problem.

[magreenblatt]

Next step is to manually delete the "src/third_party/skia" folder before running automate-git.py. Or, start with a completely clean directory.

[edgardog]

This is a clean download.
I tried deleting third_party/skia .. after running automate-git.py again :
python automate-git.py --download-dir=/home/edgardog/chroot/chrome3029/code/ --branch=3029 --x64-build --force-clean

I got the same error.
It did download skia again, but once it runs gclient sync --reset --with_branch_heads it fails.

Code: Select all

src/third_party/skia (ERROR)
----------------------------------------
[0:00:05] Started.
[0:01:59] From https://skia.googlesource.com/skia
[0:01:59]  * [new ref]         refs/branch-heads/m20_1132 -> branch-heads/m20_1132
[0:01:59]  * [new ref]         refs/branch-heads/m21_1180 -> branch-heads/m21_1180
[0:01:59]  * [new ref]         refs/branch-heads/m22_1229 -> branch-heads/m22_1229
[0:01:59]  * [new ref]         refs/branch-heads/m23_1271 -> branch-heads/m23_1271
[0:01:59]  * [new ref]         refs/branch-heads/m24_1312 -> branch-heads/m24_1312
[0:01:59]  * [new ref]         refs/branch-heads/m25_1364 -> branch-heads/m25_1364
[0:01:59]  * [new ref]         refs/branch-heads/m26_1410 -> branch-heads/m26_1410
[0:01:59]  * [new ref]         refs/branch-heads/m26_1411 -> branch-heads/m26_1411
[0:01:59]  * [new ref]         refs/branch-heads/m27_1453 -> branch-heads/m27_1453
[0:01:59]  * [new ref]         refs/branch-heads/m28_1500 -> branch-heads/m28_1500
[0:01:59]  * [new ref]         refs/branch-heads/m29_1547 -> branch-heads/m29_1547
[0:01:59]  * [new ref]         refs/branch-heads/m30_1599 -> branch-heads/m30_1599
[0:01:59]  * [new ref]         refs/branch-heads/m31_1650 -> branch-heads/m31_1650
[0:01:59]  * [new ref]         refs/branch-heads/m32_1700 -> branch-heads/m32_1700
[0:01:59]  * [new ref]         refs/branch-heads/m33_1750 -> branch-heads/m33_1750
[0:01:59]  * [new ref]         refs/branch-heads/m35_13966 -> branch-heads/m35_13966
[0:01:59]  * [new ref]         refs/branch-heads/master -> branch-heads/master
[0:01:59]  * [new ref]         refs/branch-heads/trunk -> branch-heads/trunk
_____ src/third_party/skia at 4c81ba6ba3a3270db809bf7d4c3bc782694a56a4
----------------------------------------
Traceback (most recent call last):
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 2295, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 2281, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 2030, in CMDsync
    ret = client.RunOnDeps('update', args)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 1340, in RunOnDeps
    work_queue.flush(revision_overrides, command, args, options=self._options)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient_utils.py", line 1047, in run
    self.item.run(*self.args, **self.kwargs)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 766, in run
    self.ParseDepsFile()
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient.py", line 562, in ParseDepsFile
    gclient_eval.Check(deps_content, filepath, global_scope, local_scope)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient_eval.py", line 242, in Check
    result_scope = _gclient_exec(content, global_scope, filename=path)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient_eval.py", line 187, in _gclient_exec
    _visit_in_module(stmt)
  File "/home/edgardog/chroot/chrome3029/code/depot_tools/gclient_eval.py", line 183, in _visit_in_module
    getattr(node, 'lineno', '<unknown>')))
ValueError: unexpected AST node: <_ast.Import object at 0x7fbaea8dcb90> Import(names=[alias(name='os', asname=None)]) (file u'/home/edgardog/chroot/chrome3029/code/chromium/src/third_party/skia/DEPS', line 53)
Traceback (most recent call last):
  File "automate-git.py", line 967, in <module>
    chromium_dir, depot_tools_dir)
  File "automate-git.py", line 55, in run
    args, cwd=working_dir, env=env, shell=(sys.platform == 'win32'))
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['gclient', 'sync', '--reset', '--with_branch_heads', '--jobs', '16']' returned non-zero exit status 1


Checking at 4c81ba6ba3a3270db809bf7d4c3bc782694a56a4 on https://skia.googlesource.com/skia/+/chrome/m58
I see that DEPS in here as at the end:

Code: Select all

import os
import sys
if os.path.exists('bin/fetch-gn'):
  hooks.append({ 'action': [sys.executable, 'bin/fetch-gn'] })


That was not there on m56. I have built before CEF based on 57, and that seems to be there on 57, so I don't explain myself how could I've done it before. I have the code for that build and that import os part is there too.
Maybe I'm checking out old tools or missing something on GN?

[magreenblatt]

If this is a one-time build you can try executing the commands manually one at a time (gclient sync, git checkout, etc) and performing the necessary fixes manually.

[edgardog]

OK, I got it to start building.

I had the old depot_tools I used in march. This is 4dc849f802c527ba3b2ba8fd11c91687794692ba when you look at .git/refs/heads/master.

The one automate-git.py got is the latest. With that version it fails and produces that error in import os on skia.
I copied the depot_tools I had from before, updated PATH to use the older version and exported DEPOT_TOOLS_UPDATE=0 , and now its building.

I think there is something wrong with depot_tools. ITs quite a bisect from 4dc849f802c527ba3b2ba8fd11c91687794692ba to latest.
Once I get this build working and I get some spare time I'll try to bisect it and figure out why it went wrong.

Thanks for the help

[doront99]

Hi edgardog,

I have the same error, but I don't have an older version of the depot_tools.
Do you know how can I get them?

Many Thanks,
Doron

[magreenblatt]

See https://bitbucket.org/chromiumembedded/cef/issues/2211 for the fix.