Allowing persistent cookies

[magreenblatt]

How are you running the message loop? What are you doing to "exit the app immediately"?

[callum]

Standard Windows message loop and calling CefDoMessageLoopWork(); regularly.

I shutdown in the usual way - I just mean I don't wait around after setting the cookie - I set it then tell the app to close.

bool force_close = false;
mBrowser->GetHost()->CloseBrowser(force_close);

then when my CefLifeSpanHandler::OnBeforeClose() is called, I exit the message loop

before finally calling cleaning up variables and calling CefShutdown();

[magreenblatt]

Do you call CefDoMessageLoopWork a number of times immediately before calling CefShutdown?

[callum]

I don't - once the CefLifeSpanHandler::OnBeforeClose() is triggered, I exit my message loop that is calling CefDoMesssageLoopWork().

Is that correct or should I be calling it a few times before I finally call CefShutdown() ?

[Czarek]

If you're using CefDoMessageLoopWork or external message pump then you should call CefDoMessageLoopWork several times before shutdown. See example code from cefclient:

https://github.com/chromiumembedded/cef ... win.cc#L91

Related:
https://bitbucket.org/chromiumembedded/cef/issues/1805/
viewtopic.php?f=6&t=13994
viewtopic.php?f=6&t=14154

[callum]

Got it and thank you.

That worked and cookies are now persisted even when I initiate an exit directly after the cookie is set.

Sadly, as seems to be the nature of software, I removed the code I just added to make sure it was broken before and that also worked as expected - cookies saved.

Now I know what you're supposed to do though I can find a better repro for the failure case and use the new code to fix it.

Thank you both.

[Czarek]

I guess documentation in cef_app.h for CefDoMessageLoopWork could be enhanced with a mention of this behavior. PRs are welcome