CEF 3029 compile error : ShellPluginServiceFilter derived

[user6294]

Hi

The derived class's IsPluginAvailable() override is missing the is_main_frame (bool) that is present (applied via a CEF patch) in the base class
PluginServiceFilter

I used automate-git.py for branch 3029 and followed guides on cef-project.

Your assistance would be greatly appreciately.

Thanks

C:\code\chromium_git_3029\chromium\src>ninja -C out\Debug_GN_x86
ninja: Entering directory `out\Debug_GN_x86'
[26563/45387] ACTION //cef:make_pack_header_strings(//build/toolchain/win:x86)
File includes/include/cef_pack_strings.h updated.
[26572/45387] ACTION //cef:make_pack_header_resources(//build/toolchain/win:x86)
File includes/include/cef_pack_resources.h updated.
[33151/45387] CXX obj/content/shell/content_shell_lib/shell_plugin_service_filter.obj
FAILED: obj/content/shell/content_shell_lib/shell_plugin_service_filter.obj
ninja -t msvc -e environment.x86 -- "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/content/shell/content_shell_lib/she
ll_plugin_service_filter.obj.rsp /c ../../content/shell/browser/shell_plugin_service_filter.cc /Foobj/content/shell/content_shell_lib/shell_plugin_service_filter.obj /Fd"obj/conten
t/shell/content_shell_lib_cc.pdb"
c:\code\chromium_git_3029\chromium\src\content\shell\browser\shell_plugin_service_filter.h(20): error C3668: 'content::ShellPluginServiceFilter::IsPluginAvailable': method
with override specifier 'override' did not override any base class methods
[33160/45387] CXX obj/content/shell/content_shell_lib/shell_platform_data_aura.obj
ninja: build stopped: subcommand failed.

[magreenblatt]

Build only the CEF targets:

ninja -C out\Debug_GN_x86 cef

[user6294]

Thanks that worked a treat.