Minor (?) issue in automate-git.py

Having problems with building or using CEF's C/C++ APIs? This forum is here to help. Please do not post bug reports or feature requests here.

Minor (?) issue in automate-git.py

Postby ndesktop » Tue May 01, 2018 8:57 am

Code: Select all
# Build using Ninja.
  command = 'ninja -C '
  if options.verbosebuild:
    command = 'ninja -v -C'

A space is present at the end of 'ninja -C ' but not on verbosebuild: 'ninja -v -C' (notice there is no space at the end).
Should be
Code: Select all
# Build using Ninja.
  command = 'ninja -C '
  if options.verbosebuild:
    command = 'ninja -v -C '


I cannot find automate-git.py on the repo, so I am posting it here as a crude PR.
ndesktop
Master
 
Posts: 756
Joined: Thu Dec 03, 2015 10:10 am

Re: Minor (?) issue in automate-git.py

Postby magreenblatt » Tue May 01, 2018 9:20 am

magreenblatt
Site Admin
 
Posts: 12409
Joined: Fri May 29, 2009 6:57 pm

Re: Minor (?) issue in automate-git.py

Postby ndesktop » Tue May 01, 2018 9:36 am

magreenblatt wrote:It's here: https://bitbucket.org/chromiumembedded/ ... ew-default. PR welcome.

Feel stupid for not seeing the file location. Sorry about that. Will submit PR, thank you.

Edit: PR submitted.
ndesktop
Master
 
Posts: 756
Joined: Thu Dec 03, 2015 10:10 am


Return to Support Forum

Who is online

Users browsing this forum: No registered users and 114 guests