Retry for network errors like -101, OnResourceResponse()?

[HarmlessDave]

I asked a similar question back in 2015, but I'm not sure if the answer there applies: viewtopic.php?f=6&t=12742&p=24852&hilit=%3AOnLoadError#p24852

I'm not asking about retrying a server error like 500 or 404, I'd like to be able to retry some chromium network errors, in particular -101 = NET_ERROR(CONNECTION_RESET, -101)

OnResourceResponse look like it would let me retry HTTP errors but not errors like -101 since I can only look at the response header not chromium errors. Am I wrong and a header with the network error gets added? (If yes, a sample would be very helpful.)

OnLoadError is missing the request object and has no built-in retry option, so the only way I could see to use it would be to do my own caching of requests for frames in some earlier event, then use that cached request if I want to retry. Can anyone suggest a better approach?

[magreenblatt]

Is your intent to only retry failed frame navigations, or all resource requests that fail? For the latter I would expect a decently written web app to have its own retry logic (if an XHR fails, for example), and you probably shouldn't interfere with that.

[HarmlessDave]

Is your intent to only retry failed frame navigations, or all resource requests that fail? For the latter I would expect a decently written web app to have its own retry logic (if an XHR fails, for example), and you probably shouldn't interfere with that.

We'd just like to retry failed frame navigations, not other resources or XHR.

[magreenblatt]

What about calling LoadURL(failedUrl) from OnLoadError?

[Czarek]

If there are issues with calling LoadURL inside that callback then try using CefPostTask to call LoadURL, so that it executes after OnLoadError returns.

[HarmlessDave]

What about calling LoadURL(failedUrl) from OnLoadError?

If there are issues with calling LoadURL inside that callback then try using CefPostTask to call LoadURL, so that it executes after OnLoadError returns.

Thanks, that should work for a GET request. Is there any way to know just from the passed parameters that the failed request was a GET not a POST? Or a way to get the failed CefRequest so a POST would work too?

Code: Select all

::OnLoadError(CefRefPtr<CefBrowser> browser,
     CefRefPtr<CefFrame> frame,
     ErrorCode errorCode,
     const CefString& errorText,
     const CefString& failedUrl)

[Czarek]

I've tested in cefclient and CefBrowser::Reload doesn't work on POST requests (by using Reload button). Additionally when I use "Back" button I noticed "ERR_CACHE_MISS -400".

It seems caching the request data in OnBeforeBrowse (and using OnBeforeResourceLoad for POST requests, see http://magpcss.org/ceforum/viewtopic.php?f=6&t=15750) is the way to go.

Regarding using CefPostTask I mentioned earlier. In the past if I recall correctly, I've sometimes had crashes when initiating navigation from OnLoadError, that's why I suggested it. It's safer to do it that way.

[HarmlessDave]

Regarding using CefPostTask I mentioned earlier. In the past if I recall correctly, I've sometimes had crashes when initiating navigation from OnLoadError, that's why I suggested it. It's safer to do it that way.

Thanks, I've had similar glitches trying to do replacement navigations in OnBeforeBrowse after canceling a navigation, so I've used CefPostTask and Windows PostMessage for that before.