make_distrib fails - MacOS 13.4.1 / XCode 14.0

[logicp]

I don’t think you need to do a manual build. You can run the automated build with the additional GN_DEFINES arguments necessary to enable proprietary codecs.

Pardon, I misinformed, the reason the build has to be manual is because a patch needs to be applied after creating the projects

[logicp]

If the manual process won't work with the `make_distrib` script, is there someway I can go about copying steps to create a distribution package by hand?

[magreenblatt]

You can fork the CEF repository, commit your patch file, and then build your fork using the automated method. See command-line arguments supported by automate-git.py.

[logicp]

You can fork the CEF repository, commit your patch file, and then build your fork using the automated method. See command-line arguments supported by automate-git.py.

Thanks for that advice.

I went ahead and forked the repo and tried two strategies:
1. Modifying the 5672 branch
2. Using a custom branch

I then proceed by doing the following:
1. Set variables

Code: Select all

export PATH=/Users/embucksh/code/depot_tools:$PATH
export GN_DEFINES='proprietary_codecs=true ffmpeg_branding="Chrome" is_official_build=true'
export GN_ARGUMENTS='--ide=vs2019 --sln=cef --filters=//cef/*'


2. Run command

Code: Select all

python3 automate-git.py --download-dir=/Users/embucksh/code/chromium_git --branch=5672 --url=https://github.com/RibbonCommunications/distant-cef.git --minimal-distrib --client-distrib --force-clean --x64-build --with-pgo-profiles


(alternatively, I use --checkout=<custom branch>

In each case, after the automate script checks out and clones third party libraries, I come to the following result:

Code: Select all

Error: 85> Wrong keys 'git_dependencies' in {'vars': {'boringssl_git': 'https://boringssl.googlesource.com', 'chromium_git': 'https://chromium.googlesource.com', 'quiche_git': 'https://quiche.googlesource.com', 'github': 'https://github.com', 'build_with_chromium': False, 'checkout_clang_coverage_tools': True, 'gn_version': 'git_revision:5e19d2fb166fbd4f6f32147fbb2f497091a54ad8', 'clang_format_revision': 'e435ad79c17b1888b34df88d6a30a094936e3836', 'SUBMODULE_MIGRATION': 'True'}, 'use_relative_paths': True, 'git_dependencies': 'SYNC', 'deps': {'buildtools': {'url': 'https://chromium.googlesource.com/chromium/src/buildtools@3c7e3f1b8b1e4c0b6ec693430379cea682de78d6', 'condition': 'not build_with_chromium'}, 'third_party/clang-format/script': {'url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git@e5337933f2951cacd3aeacd238ce4578163ca0b9', 'condition': 'not build_with_chromium'}, 'buildtools/linux64': {'packages': [{'package': 'gn/gn/linux-amd64', 'version': 'git_revision:811d332bd90551342c5cbd39e133aa276022d7f8'}], 'dep_type': 'cipd', 'condition': 'host_os == "linux" and not build_with_chromium'}, 'buildtools/mac': {'packages': [{'package': 'gn/gn/mac-${arch}', 'version': 'git_revision:811d332bd90551342c5cbd39e133aa276022d7f8'}], 'dep_type': 'cipd', 'condition': 'host_os == "mac" and not build_with_chromium'}, 'third_party/ninja': {'packages': [{'package': 'infra/3pp/tools/ninja/${platform}', 'version': 'version:2@1.8.2.chromium.3'}], 'dep_type': 'cipd', 'condition': 'not build_with_chromium'}, 'third_party/protobuf/src': {'url': 'https://chromium.googlesource.com/external/github.com/protocolbuffers/protobuf.git@909a0f36a10075c4b4bc70fdee2c7e32dd612a72', 'condition': 'not build_with_chromium'}, 'third_party/libprotobuf-mutator/src': {'url': 'https://chromium.googlesource.com/external/github.com/google/libprotobuf-mutator.git@a304ec48dcf15d942607032151f7e9ee504b5dcf', 'condition': 'not build_with_chromium'}, 'third_party/zlib/src': {'url': 'https://github.com/madler/zlib.git@04f42ceca40f73e2978b50e93806c2a18c1281fc', 'condition': 'not build_with_chromium'}, 'third_party/jsoncpp/src': {'url': 'https://chromium.googlesource.com/external/github.com/open-source-parsers/jsoncpp.git@5defb4ed1a4293b8e2bf641e16b156fb9de498cc', 'condition': 'not build_with_chromium'}, 'third_party/googletest/src': {'url': 'https://chromium.googlesource.com/external/github.com/google/googletest.git@b495f72f1f096135cf9cf8c7879b5b89250de50a', 'condition': 'not build_with_chromium'}, 'third_party/boringssl/src': {'url': 'https://boringssl.googlesource.com/boringssl.git@51ed32f1971956a904ce7b3a7ff10716e76eecd4', 'condition': 'not build_with_chromium'}, 'third_party/quiche/src': {'url': 'https://quiche.googlesource.com/quiche.git@7b58beaec1f65b8e074ddb81796e34f3d6d83cf3', 'condition': 'not build_with_chromium'}, 'third_party/tinycbor/src': 'https://chromium.googlesource.com/external/github.com/intel/tinycbor.git@d393c16f3eb30d0c47e6f9d92db62272f0ec4dc7', 'third_party/abseil/src': {'url': 'https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp.git@78be63686ba732b25052be15f8d6dee891c05749', 'condition': 'not build_with_chromium'}, 'third_party/libfuzzer/src': {'url': 'https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git@debe7d2d1982e540fbd6bd78604bf001753f9e74', 'condition': 'not build_with_chromium'}, 'third_party/modp_b64': {'url': 'https://chromium.googlesource.com/chromium/src/third_party/modp_b64@3643752c065d984647f0ded68a9a01926fb3b9cd', 'condition': 'not build_with_chromium'}, 'third_party/valijson/src': {'url': 'https://github.com/tristanpenman/valijson.git@78ac8a737df56b5334354efe104ea8f99e2a2f00', 'condition': 'not build_with_chromium'}}, 'hooks': [{'name': 'clang_update_script', 'pattern': '.', 'condition': 'not build_with_chromium', 'action': ['tools/download-clang-update-script.py', '--output', 'tools/clang/scripts/update.py']}, {'name': 'update_clang', 'pattern': '.', 'condition': 'not build_with_chromium', 'action': ['python3', 'tools/clang/scripts/update.py']}, {'name': 'clang_coverage_tools', 'pattern': '.', 'condition': 'not build_with_chromium and checkout_clang_coverage_tools', 'action': ['python3', 'tools/clang/scripts/update.py', '--package=coverage_tools']}, {'name': 'clang_format_linux64', 'pattern': '.', 'action': ['download_from_google_storage.py', '--no_resume', '--no_auth', '--bucket', 'chromium-clang-format', '-s', 'buildtools/linux64/clang-format.sha1'], 'condition': 'host_os == "linux" and not build_with_chromium'}, {'name': 'clang_format_mac_x64', 'pattern': '.', 'action': ['download_from_google_storage.py', '--no_resume', '--no_auth', '--bucket', 'chromium-clang-format', '-s', 'buildtools/mac/clang-format.x64.sha1'], 'condition': 'host_os == "mac" and host_cpu == "x64" and not build_with_chromium'}, {'name': 'clang_format_mac_arm64', 'pattern': '.', 'action': ['download_from_google_storage.py', '--no_resume', '--no_auth', '--bucket', 'chromium-clang-format', '-s', 'buildtools/mac/clang-format.arm64.sha1'], 'condition': 'host_os == "mac" and host_cpu == "arm64" and not build_with_chromium'}], 'include_rules': ['+util', '+platform/api', '+platform/base', '+platform/test', '+testing/util', '+third_party', '-discovery', '+discovery/common', '+discovery/dnssd/public', '+discovery/mdns/public', '+discovery/public', '-third_party/abseil', '+absl/algorithm/container.h', '+absl/base/thread_annotations.h', '+absl/hash/hash.h', '+absl/hash/hash_testing.h', '+absl/strings/ascii.h', '+absl/strings/match.h', '+absl/strings/numbers.h', '+absl/strings/str_cat.h', '+absl/strings/str_join.h', '+absl/strings/str_replace.h', '+absl/strings/str_split.h', '+absl/strings/string_view.h', '+absl/strings/substitute.h', '+absl/types/optional.h', '+absl/types/span.h', '+absl/types/variant.h', '-third_party/boringssl', '-third_party/googletest', '+gtest', '+gmock']}


Have you any idea what this could be?

[logicp]

I have seen a different result if using --checkout instead of --branch with the automate script:

Code: Select all

Error: 34> Wrong keys 'git_dependencies' in {'vars': {'chromium_git': 'https://chromium.googlesource.com', 'dawn_git': 'https://dawn.googlesource.com', 'github_git': 'https://github.com', 'swiftshader_git': 'https://swiftshader.googlesource.com', 'dawn_standalone': True, 'dawn_node': False, 'dawn_cmake_version': 'version:2@3.23.3', 'dawn_cmake_win32_sha1': 'b106d66bcdc8a71ea2cdf5446091327bfdb1bcd7', 'dawn_gn_version': 'git_revision:bd99dbf98cbdefe18a4128189665c5761263bcfb', 'dawn_ninja_version': 'version:2@1.11.1.chromium.6', 'dawn_go_version': 'version:2@1.18.4', 'node_darwin_arm64_sha': '31859fc1fa0994a95f44f09c367d6ff63607cfde', 'node_darwin_x64_sha': '16dfd094763b71988933a31735f9dea966f9abd6', 'node_linux_x64_sha': 'ab9544e24e752d3d17f335fb7b2055062e582d11', 'node_win_x64_sha': '5ef847033c517c499f56f9d136d159b663bab717', 'generate_location_tags': False, 'checkout_clang_tidy': False, 'download_remoteexec_cfg': False, 'rbe_instance': 'projects/rbe-chrome-untrusted/instances/default_instance', 'rewrapper_cfg_project': '', 'reclient_package': 'infra/rbe/client/', 'reclient_version': 're_client_version:0.108.0.7cdbbe9-gomaip', 'SUBMODULE_MIGRATION': 'True'}, 'use_relative_paths': True, 'gclient_gn_args_file': 'build/config/gclient_args.gni', 'gclient_gn_args': ['generate_location_tags'], 'git_dependencies': 'SYNC', 'deps': {'build': {'url': 'https://chromium.googlesource.com/chromium/src/build@5885d3c24833ad72845a52a1b913a2b8bc651b56', 'condition': 'dawn_standalone'}, 'buildtools': {'url': 'https://chromium.googlesource.com/chromium/src/buildtools@79ab87fa54614258c4c95891e873223371194525', 'condition': 'dawn_standalone'}, 'third_party/clang-format/script': {'url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git@8b525d2747f2584fc35d8c7e612e66f377858df7', 'condition': 'dawn_standalone'}, 'buildtools/linux64': {'packages': [{'package': 'gn/gn/linux-amd64', 'version': 'git_revision:bd99dbf98cbdefe18a4128189665c5761263bcfb'}], 'dep_type': 'cipd', 'condition': 'dawn_standalone and host_os == "linux"'}, 'buildtools/mac': {'packages': [{'package': 'gn/gn/mac-${arch}', 'version': 'git_revision:bd99dbf98cbdefe18a4128189665c5761263bcfb'}], 'dep_type': 'cipd', 'condition': 'dawn_standalone and host_os == "mac"'}, 'buildtools/win': {'packages': [{'package': 'gn/gn/windows-amd64', 'version': 'git_revision:bd99dbf98cbdefe18a4128189665c5761263bcfb'}], 'dep_type': 'cipd', 'condition': 'dawn_standalone and host_os == "win"'}, 'third_party/libc++/src': {'url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git@84fb809dd6dae36d556dc0bb702c6cc2ce9d4b80', 'condition': 'dawn_standalone'}, 'third_party/libc++abi/src': {'url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git@d4760c0af99ccc9bce077960d5ddde4d66146c05', 'condition': 'dawn_standalone'}, 'tools/clang': {'url': 'https://chromium.googlesource.com/chromium/src/tools/clang@effd9257d456f2d42e9e22fa4f37a24d8cf0b5b5', 'condition': 'dawn_standalone'}, 'tools/clang/dsymutil': {'packages': [{'package': 'chromium/llvm-build-tools/dsymutil', 'version': 'M56jPzDv1620Rnm__jTMYS62Zi8rxHVq7yw0qeBFEgkC'}], 'condition': 'dawn_standalone and (checkout_mac or checkout_ios)', 'dep_type': 'cipd'}, 'testing': {'url': 'https://chromium.googlesource.com/chromium/src/testing@166db27fd0d53afc0c716b1ae9c15725e380871f', 'condition': 'dawn_standalone'}, 'third_party/googletest': {'url': 'https://chromium.googlesource.com/external/github.com/google/googletest@7a7231c442484be389fdf01594310349ca0e42a8', 'condition': 'dawn_standalone'}, 'third_party/catapult': {'url': 'https://chromium.googlesource.com/catapult.git@dd218dfd815774289f8a81015f7a3131f72afbde', 'condition': 'dawn_standalone'}, 'third_party/google_benchmark/src': {'url': 'https://chromium.googlesource.com/external/github.com/google/benchmark.git@efc89f0b524780b1994d5dddd83a92718e5be492', 'condition': 'dawn_standalone'}, 'third_party/jinja2': {'url': 'https://chromium.googlesource.com/chromium/src/third_party/jinja2@515dd10de9bf63040045902a4a310d2ba25213a0', 'condition': 'dawn_standalone'}, 'third_party/markupsafe': {'url': 'https://chromium.googlesource.com/chromium/src/third_party/markupsafe@006709ba3ed87660a17bd4548c45663628f5ed85', 'condition': 'dawn_standalone'}, 'third_party/glfw': {'url': 'https://chromium.googlesource.com/external/github.com/glfw/glfw@62e175ef9fae75335575964c845a302447c012c7'}, 'third_party/vulkan_memory_allocator': {'url': 'https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator@e87036508bb156f9986ea959323de1869e328f58', 'condition': 'dawn_standalone'}, 'third_party/angle': {'url': 'https://chromium.googlesource.com/angle/angle@d7e914da5f99966a3358aab956af8eea988711c8', 'condition': 'dawn_standalone'}, 'third_party/swiftshader': {'url': 'https://swiftshader.googlesource.com/SwiftShader@c315c894b9d529b8e7d3753b1217630aa8821d75', 'condition': 'dawn_standalone'}, 'third_party/vulkan-deps': {'url': 'https://chromium.googlesource.com/vulkan-deps@04381109ae471509060a985c908fd53c4b981a31', 'condition': 'dawn_standalone'}, 'third_party/zlib': {'url': 'https://chromium.googlesource.com/chromium/src/third_party/zlib@526382e41c9c5275dc329db4328b54e4f344a204', 'condition': 'dawn_standalone'}, 'third_party/abseil-cpp': {'url': 'https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp@bc3ab29356a081d0b5dd4ac55e30f4b45d8794cc', 'condition': 'dawn_standalone'}, 'third_party/dxc': {'url': 'https://chromium.googlesource.com/external/github.com/microsoft/DirectXShaderCompiler@d9c07e90e1a7fa2654d4b52e6f5704b986549c15'}, 'third_party/dxheaders': {'url': 'https://chromium.googlesource.com/external/github.com/microsoft/DirectX-Headers@980971e835876dc0cde415e8f9bc646e64667bf7', 'condition': 'host_os != "win"'}, 'third_party/webgpu-cts': {'url': 'https://chromium.googlesource.com/external/github.com/gpuweb/cts@02f3426192fcb2c84f757d2d1887fd982a974dca', 'condition': 'build_with_chromium'}, 'third_party/node-api-headers': {'url': 'https://github.com/nodejs/node-api-headers.git@d68505e4055ecb630e14c26c32e5c2c65e179bba', 'condition': 'dawn_node'}, 'third_party/node-addon-api': {'url': 'https://github.com/nodejs/node-addon-api.git@4a3de56c3e4ed0031635a2f642b27efeeed00add', 'condition': 'dawn_node'}, 'third_party/gpuweb': {'url': 'https://github.com/gpuweb/gpuweb.git@913189072715569b8ad60e5c2e38e501273bd5b0', 'condition': 'dawn_node'}, 'tools/golang': {'packages': [{'package': 'infra/3pp/tools/go/${platform}', 'version': 'version:2@1.18.4'}], 'dep_type': 'cipd'}, 'tools/cmake': {'condition': 'dawn_node and (host_os == "mac" or host_os == "linux")', 'packages': [{'package': 'infra/3pp/tools/cmake/${platform}', 'version': 'version:2@3.23.3'}], 'dep_type': 'cipd'}, 'third_party/ninja': {'packages': [{'package': 'infra/3pp/tools/ninja/${platform}', 'version': 'version:2@1.11.1.chromium.6'}], 'dep_type': 'cipd'}, 'buildtools/reclient': {'packages': [{'package': 'infra/rbe/client/${platform}', 'version': 're_client_version:0.112.0.ffc95d4-gomaip'}], 'dep_type': 'cipd', 'condition': 'dawn_standalone'}, 'third_party/protobuf': {'url': 'https://chromium.googlesource.com/external/github.com/protocolbuffers/protobuf.git@fde7cf7358ec7cd69e8db9be4f1fa6a5c431386a', 'condition': 'dawn_standalone'}}, 'hooks': [{'name': 'sysroot_x86', 'pattern': '.', 'condition': 'dawn_standalone and checkout_linux and (checkout_x86 or checkout_x64)', 'action': ['python3', 'build/linux/sysroot_scripts/install-sysroot.py', '--arch=x86']}, {'name': 'sysroot_x64', 'pattern': '.', 'condition': 'dawn_standalone and checkout_linux and checkout_x64', 'action': ['python3', 'build/linux/sysroot_scripts/install-sysroot.py', '--arch=x64']}, {'name': 'mac_toolchain', 'pattern': '.', 'condition': 'dawn_standalone and checkout_mac', 'action': ['python3', 'build/mac_toolchain.py']}, {'name': 'ciopfs_linux', 'pattern': '.', 'condition': 'dawn_standalone and checkout_win and host_os == "linux"', 'action': ['download_from_google_storage', '--no_resume', '--no_auth', '--bucket', 'chromium-browser-clang/ciopfs', '-s', 'build/ciopfs.sha1']}, {'name': 'win_toolchain', 'pattern': '.', 'condition': 'dawn_standalone and checkout_win', 'action': ['python3', 'build/vs_toolchain.py', 'update', '--force']}, {'name': 'clang', 'pattern': '.', 'action': ['python3', 'tools/clang/scripts/update.py'], 'condition': 'dawn_standalone'}, {'name': 'clang_tidy', 'pattern': '.', 'condition': 'dawn_standalone and checkout_clang_tidy', 'action': ['python3', 'tools/clang/scripts/update.py', '--package=clang-tidy']}, {'name': 'rc_win', 'pattern': '.', 'condition': 'dawn_standalone and checkout_win and host_os == "win"', 'action': ['download_from_google_storage', '--no_resume', '--no_auth', '--bucket', 'chromium-browser-clang/rc', '-s', 'build/toolchain/win/rc/win/rc.exe.sha1']}, {'name': 'rc_linux', 'pattern': '.', 'condition': 'dawn_standalone and checkout_win and host_os == "linux"', 'action': ['download_from_google_storage', '--no_resume', '--no_auth', '--bucket', 'chromium-browser-clang/rc', '-s', 'build/toolchain/win/rc/linux64/rc.sha1']}, {'name': 'clang_format_win', 'pattern': '.', 'condition': 'dawn_standalone and host_os == "win"', 'action': ['download_from_google_storage', '--no_resume', '--no_auth', '--bucket', 'chromium-clang-format', '-s', 'buildtools/win/clang-format.exe.sha1']}, {'name': 'clang_format_mac_x64', 'pattern': '.', 'condition': 'dawn_standalone and host_os == "mac" and host_cpu == "x64"', 'action': ['download_from_google_storage', '--no_resume', '--no_auth', '--bucket', 'chromium-clang-format', '-s', 'buildtools/mac/clang-format.x64.sha1', '-o', 'buildtools/mac/clang-format']}, {'name': 'clang_format_mac_arm64', 'pattern': '.', 'condition': 'dawn_standalone and host_os == "mac" and host_cpu == "arm64"', 'action': ['download_from_google_storage', '--no_resume', '--no_auth', '--bucket', 'chromium-clang-format', '-s', 'buildtools/mac/clang-format.arm64.sha1', '-o', 'buildtools/mac/clang-format']}, {'name': 'clang_format_linux', 'pattern': '.', 'condition': 'dawn_standalone and host_os == "linux"', 'action': ['download_from_google_storage', '--no_resume', '--no_auth', '--bucket', 'chromium-clang-format', '-s', 'buildtools/linux64/clang-format.sha1']}, {'name': 'lastchange', 'pattern': '.', 'condition': 'dawn_standalone', 'action': ['python3', 'build/util/lastchange.py', '-o', 'build/util/LASTCHANGE']}, {'name': 'cmake_win32', 'pattern': '.', 'condition': 'dawn_node and host_os == "win"', 'action': ['download_from_google_storage', '--no_resume', '--platform=win32', '--no_auth', '--bucket', 'chromium-tools', 'b106d66bcdc8a71ea2cdf5446091327bfdb1bcd7', '-o', 'tools/cmake-win32.zip']}, {'name': 'cmake_win32_extract', 'pattern': '.', 'condition': 'dawn_node and host_os == "win"', 'action': ['python3', 'scripts/extract.py', 'tools/cmake-win32.zip', 'tools/cmake-win32/']}, {'name': 'node_linux64', 'pattern': '.', 'condition': 'dawn_node and host_os == "linux"', 'action': ['download_from_google_storage', '--no_resume', '--extract', '--no_auth', '--bucket', 'chromium-nodejs/16.13.0', 'ab9544e24e752d3d17f335fb7b2055062e582d11', '-o', 'third_party/node/node-linux-x64.tar.gz']}, {'name': 'node_mac', 'pattern': '.', 'condition': 'dawn_node and host_os == "mac"', 'action': ['download_from_google_storage', '--no_resume', '--extract', '--no_auth', '--bucket', 'chromium-nodejs/16.13.0', '16dfd094763b71988933a31735f9dea966f9abd6', '-o', 'third_party/node/node-darwin-x64.tar.gz']}, {'name': 'node_mac_arm64', 'pattern': '.', 'condition': 'dawn_node and host_os == "mac"', 'action': ['download_from_google_storage', '--no_resume', '--extract', '--no_auth', '--bucket', 'chromium-nodejs/16.13.0', '31859fc1fa0994a95f44f09c367d6ff63607cfde', '-o', 'third_party/node/node-darwin-arm64.tar.gz']}, {'name': 'node_win', 'pattern': '.', 'condition': 'dawn_node and host_os == "win"', 'action': ['download_from_google_storage', '--no_resume', '--no_auth', '--bucket', 'chromium-nodejs/16.13.0', '5ef847033c517c499f56f9d136d159b663bab717', '-o', 'third_party/node/node.exe']}, {'name': 'fetch_reclient_cfgs', 'pattern': '.', 'condition': 'download_remoteexec_cfg and dawn_standalone', 'action': ['python3', 'buildtools/reclient_cfgs/fetch_reclient_cfgs.py', '--rbe_instance', 'projects/rbe-chrome-untrusted/instances/default_instance', '--reproxy_cfg_template', 'reproxy.cfg.template', '--rewrapper_cfg_project', '', '--quiet']}], 'recursedeps': ['third_party/vulkan-deps']}


[magreenblatt]

Error: 34> Wrong keys 'git_dependencies'

See viewtopic.php?f=6&t=19525#p53955

[logicp]

Error: 34> Wrong keys 'git_dependencies'

See viewtopic.php?f=6&t=19525#p53955

Thanks for this.

I see that the release versions this fix pertains to is a bit higher, but I went ahead and applied it to my branch and used the --checkout option when running automate. Since I am building for Mac, I had to use the `--with-pgo-profiles` option, and this strangely resulted in the build failing due to it complaining about `gclient runhooks` not having been run. It's a bit strange, because I could have sworn that it DOES run normally.

Here's what I ran (branch `distant18` which is based off of Release `5672` with the `CHROMIUM_BUILD_COMPATIBILITY.txt` fix applied:

Code: Select all

python3 automate-git.py --download-dir=/Users/embucksh/code/chromium_git --checkout=distant18-depot-tools  --url=https://github.com/RibbonCommunications/distant-cef.git --minimal-distrib --client-distrib --force-clean --x64-build --with-pgo-profiles

Here's the output:

Code: Select all

ERROR at //build/config/compiler/pgo/BUILD.gn:81:23: Script returned non-zero exit code.
      pgo_data_path = exec_script("//tools/update_pgo_profiles.py",
                      ^----------
Current dir: /Users/embucksh/code/chromium_git/chromium/src/out/Release_GN_x64/
Command: python3 /Users/embucksh/code/chromium_git/chromium/src/tools/update_pgo_profiles.py --target mac get_profile_path
Returned 1.
stderr:

Traceback (most recent call last):
  File "/Users/embucksh/code/chromium_git/chromium/src/tools/update_pgo_profiles.py", line 154, in <module>
    sys.exit(main())
  File "/Users/embucksh/code/chromium_git/chromium/src/tools/update_pgo_profiles.py", line 150, in main
    return args.func(args)
  File "/Users/embucksh/code/chromium_git/chromium/src/tools/update_pgo_profiles.py", line 106, in _get_profile_path
    raise RuntimeError(
RuntimeError: requested profile "/Users/embucksh/code/chromium_git/chromium/src/chrome/build/pgo_profiles/chrome-mac-5672-1683044598-1ecdf98be9977250bc15449046a5b6e80cbab56a.profdata" doesn't exist, please make sure "checkout_pgo_profiles" is set to True in the "custom_vars" section of your .gclient file, e.g.:
solutions = [
  {
    "name": "src",
    # ...
    "custom_vars": {
      "checkout_pgo_profiles": True,
    },
  },
],
and then run "gclient runhooks" to download it. You can also simply disable the PGO optimizations by setting |chrome_pgo_phase = 0| in your GN arguments.

See //build/config/BUILDCONFIG.gn:352:3: which caused the file to be included.
  "//build/config/compiler/pgo:default_pgo_flags",


[magreenblatt]

I had to use the `--with-pgo-profiles` option, and this strangely resulted in the build failing

Try adding --force-config to the automate-git.py command line.

[logicp]

I had to use the `--with-pgo-profiles` option, and this strangely resulted in the build failing

Try adding --force-config to the automate-git.py command line.

That allowed the build to continue, with both the Release and Debug builds completing, but the `make_distrib` failed again with the following:

Code: Select all

Verifying exported symbols...
Verifying imported (undefined) symbols...
Transferring /Users/embucksh/code/chromium_git/chromium/src/out/Debug_GN_x64/cefclient.app/Contents/Frameworks/Chromium Embedded Framework.framework/Versions/A directory.
Creating /Users/embucksh/code/chromium_git/chromium/src/cef/binary_distrib/cef_binary_113.0.0-distant18-depot-tools.2778+g716ad60+chromium-113.0.5672.129_macosx64_debug_symbols directory.
Failed to copy directory from /Users/embucksh/code/chromium_git/chromium/src/out/Debug_GN_x64/Chromium Embedded Framework.dSYM to /Users/embucksh/code/chromium_git/chromium/src/cef/binary_distrib/cef_binary_113.0.0-distant18-depot-tools.2778+g716ad60+chromium-113.0.5672.129_macosx64_debug_symbols/Chromium Embedded Framework.dSYM: No such file or directoryTraceback (most recent call last):
  File "/Users/embucksh/code/chromium_git/chromium/src/cef/tools/make_distrib.py", line 1098, in <module>
    copy_dir(
  File "/Users/embucksh/code/chromium_git/chromium/src/cef/tools/file_util.py", line 122, in copy_dir
    shutil.copytree(src, dst)
  File "/Users/embucksh/Downloads/xcode142/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/shutil.py", line 555, in copytree
    with os.scandir(src) as itr:
FileNotFoundError: [Errno 2] No such file or directory: '/Users/embucksh/code/chromium_git/chromium/src/out/Debug_GN_x64/Chromium Embedded Framework.dSYM'
Traceback (most recent call last):
  File "/Users/embucksh/code/automate/automate-git.py", line 1494, in <module>
    run(path, cef_tools_dir, depot_tools_dir)
  File "/Users/embucksh/code/automate/automate-git.py", line 66, in run
    return subprocess.check_call(
  File "/Users/embucksh/Downloads/xcode142/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/subprocess.py", line 373, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/Users/embucksh/Downloads/xcode142/Xcode.app/Contents/Developer/usr/bin/python3', 'make_distrib.py', '--output-dir=../binary_distrib/', '--ninja-build', '--x64-build']' returned non-zero exit status 1.


[magreenblatt]

FileNotFoundError: [Errno 2] No such file or directory: '/Users/embucksh/code/chromium_git/chromium/src/out/Debug_GN_x64/Chromium Embedded Framework.dSYM'

What are your GN_DEFINES?