Pepper flash opens a console window on Windows

[amaitland]

You can follow the upstream issue (currently unresolved)

https://code.google.com/p/chromium/issu ... ?id=508002

[iegor]

From what I can gather, pepper flash plugin just call CreateProcess with command line like "C:\Windows\system32\cmd.exe /c echo NOT SANDBOXED". As I understand, in case of sandboxed plugin's process this call will be forbidden therefore you don't see console window.

[magreenblatt]

From what I can gather, pepper flash plugin just call CreateProcess with command line like "C:\Windows\system32\cmd.exe /c echo NOT SANDBOXED". As I understand, in case of sandboxed plugin's process this call will be forbidden therefore you don't see console window.

If you've verified that this is what's happening please add that information to the Chromium issue.

[amaitland]

It appears that Chromium issue has been marked as wontfix, so I'd suggest anyone that this problem affects please comment asking the devs politely to reconsider.

https://code.google.com/p/chromium/issues/detail?id=508002

[Czarek]

I was thinking about creating a Chromium patch and including it in CEF - there are already a bunch of Chromium patches in CEF. However when searching Chromium code for "NOT SANDBOXED" there are no results. I've also looked for Debug/Output functions in ppapi code and looks like this console message doesn't use any of official API. Pepper Flash Plugin is not open source so it's not possible to patch it, but.. I've opened pepflashplayer.dll and libpepflashplayer.so in a hex editor and found this code: "echo NOT SANDBOXED". Attaching screenshot below. Looks like this can be easily fixed by modifying a few bytes in dll/so files :>

NOT SANDBOXED string in pepflashplayer.dll

NOT SANDBOXED.jpg (322 KiB) Viewed 18065 times

[amaitland]

How do you think this would go with virus scanners?

Is it worth posting your findings on the chromium issue?

[Czarek]

How do you think this would go with virus scanners?

Modifying even only a few bytes makes this a totally new binary file and as we know virus scanners are unpredictable. Only after checking with virustotal.com you will know.

Is it worth posting your findings on the chromium issue?

Feel free to post any of it on the chromium issue. Knowing alone that this can't be fixed in Chromium source is an useful information.

[Czarek]

In comment #15 in the issue (that resulted in marking as won't fix) it was said that they have no idea where the message is coming from - now at least we know this is hardcoded in the plugin code.

[Tsury]

Why not just make the patch and let us check it with different anti virus programs?

[amaitland]

For licensing reasons you wouldn't be allowed to distribute the resulting binary. Modifying the binary may have some legal implications.

The technical change is the easy part!