Building new version fails with attribute directive ignored

[andrzej1k1]

I am also experiencing build error, so I created a ticket: https://bitbucket.org/chromiumembedded/cef/issues/2552/unable-to-build-due-to-warning-cfi-icall.

And I can't use the latest version because it doesn't compile due to the warnings.

I'm not seeing the`-Werror=attributes` warnings on Ubuntu 16.04 with GCC version 5.4.0, or with Clang. We should probably disable them in the CMake configuration for newer GCC versions.

I see warning in Ubuntu 16.04 + GCC 5.4.0 too:

Code: Select all

$ g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/5/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 5.4.0-6ubuntu1~16.04.10' --with-bugurl=file:///usr/share/doc/gcc-5/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-5 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-5-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-5-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-5-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.10)
$ cat sample.cc
__attribute__((no_sanitize("cfi-icall")))
int main() {
  return 1;
}
$ g++ -Wall -Werror sample.cc
sample.cc:2:10: error: 'no_sanitize' attribute directive ignored [-Werror=attributes]
 int main() {
          ^
cc1plus: all warnings being treated as errors