No "set-cookie" header in response via CefURLRequestClient

[jkum]

OS: Windows
Cef-Branch: 3865

I am facing some challenges migrating to the latest 77 build of cef.(from 72). So in my implementation I was using CefURLRequestClient\CefURLRequest to pass an custom handler to GetResourceHandler.
The response that I get now with cef-77 is omitting the set-cookie header it seems. Is this intended or there are some specific changes that needs to be taken care of now.
I went through the details provided in "Support for NetworkService" PR but didn't find any details regarding this functionality.

I have added the GetCookieAccessFilter, CanSendCookie, and CanSaveCookie functions to client handler. Also tried with/without "UR_FLAG_ALLOW_STORED_CREDENTIALS' flag.

Any input would be helpful.
Thanks.

[magreenblatt]

You need to set UR_FLAG_ALLOW_STORED_CREDENTIALS on the CefRequest passed to CefURLRequest::Create. The cookie will then be available via the associated CefCookieManager.

[jkum]

Hi Marshall

I think you got the question wrong, what I meant was that in the response returned by CefURLRequest::Create() function all other headers are present but the "Set-Cookie" header is missing, though the cookies are applied on subsequent requests using the flag you mentioned.

Tried to debug the cef code to see if the root cause can be found.
Reached til the proxy_url_loader_factory.cc file, and even in the InterceptedRequest::OnHeadersReceived() function the Set-Cookie header is missing.

Do you think this is an issue with chromium ?

I tried to debug further and last point i could reach was the TrustedHeaderClientStubDispatch::AcceptWithResponder() function in network_context.mojom.cc file and looks like the message that is passed itself has the set-cookie header missing, it would be great if you could point me to the code where the message(response) is being formed and dispatched.

Thanks for your help.

[magreenblatt]

The Set-Cookie header is handled internally. You can retrieve the cookie value from CefCookieManager.

[jkum]

Hey Marshall

As suggested by you now I am trying to use CefCookieManager::GetGlobalManager(NULL)->VisitUrlCookies() to retrive the cookie values.
Getting into a few issues with this approach as well.
I am calling VisitUrlCookies function from within CefResourceHandler::GetResponseHeaders() which is called on IO thread, whereas the CefCookieManager::VisitUrlCookies function and the CefCookieVisitor::Visit are called on UI thread.

Thus I am facing an synchronization issue. I tried to use CefWaitableEvent as used in cookie tests , but looks like the wait() function cant be used on IO/UI thread.
Using std::condition_variable present another challenge, it looks like the VisitUrlCookies task is posted on UI thread but the CefCookieVisitor::Visit() function is not called until the control leaves CefResourceHandler::GetResponseHeaders() , placed a long wait after the VisitUrlCookies call but didnt get the control inside CefCookieVisitor::Visit() thus the cookie data is not available at next step.

Any suggestions as to how synchronization can be achieved.

Thanks

[magreenblatt]

You should delay execution of the ProcessRequest callback until after you have asynchronously retrieved all necessary information.

[alienhe]

i met this question too,can anybody gives a help~