Page 2 of 2

Re: cef crash after windows wake up

PostPosted: Tue Sep 15, 2020 9:37 pm
by xiaolong1976
magreenblatt wrote:@ xiaolong1976: What CEF version are you using? Does the problem reproduce with the CEF sample apps?


Hi magreenblatt, the libcef version :
0:009> lmvm libcef
Browse full module list
start end module name
51af0000 5774b000 libcef (private pdb symbols) C:\symbols\sym\libcef.dll.pdb\C39B025DC1417B784C4C44205044422E1\libcef.dll.pdb
Loaded symbol image file: libcef.dll
Image path: C:\Program Files (x86)\Cisco Systems\Cisco Jabber\libcef.dll
Image name: libcef.dll
Browse all global symbols functions data
Timestamp: Sun Jul 28 13:00:00 2019 (5D3D2BD0)
CheckSum: 05B0F305
ImageSize: 05C5B000
File version: 76.1.9.0
Product version: 76.1.9.0
File flags: 0 (Mask 17)
File OS: 4 Unknown Win32
File type: 2.0 Dll
File date: 00000000.00000000
Translations: 0409.04b0
ProductName: Chromium Embedded Framework (CEF) Dynamic Link Library
InternalName: libcef
OriginalFilename: libcef.dll
ProductVersion: 76.1.9+g2cf916e+chromium-76.0.3809.87
FileVersion: 76.1.9+g2cf916e+chromium-76.0.3809.87
FileDescription: Chromium Embedded Framework (CEF) Dynamic Link Library
LegalCopyright: Copyright (C) 2019 The Chromium Embedded Framework Authors

Re: cef crash after windows wake up

PostPosted: Tue Sep 15, 2020 9:49 pm
by xiaolong1976
magreenblatt wrote:@ xiaolong1976: What CEF version are you using? Does the problem reproduce with the CEF sample apps?

Hi magreenblatt,
I can't reproduce it, in the last two years, we only received the crash reports 2 times, which has the same crash stack.
we have not seen it in CEF sample apps because of limited test numbers.

Re: cef crash after windows wake up

PostPosted: Tue Sep 15, 2020 9:55 pm
by magreenblatt
You’re using an old and unsupported CEF version, I suggest you update.

Re: cef crash after windows wake up

PostPosted: Tue Sep 15, 2020 10:27 pm
by xiaolong1976
magreenblatt wrote:You’re using an old and unsupported CEF version, I suggest you update.


Ok, thanks a lot.
do you know which version (commit) includes this fix?

Re: cef crash after windows wake up

PostPosted: Tue Sep 15, 2020 10:32 pm
by magreenblatt
I don’t know if the issue is fixed. You will need to test and see.

Re: cef crash after windows wake up

PostPosted: Wed Sep 16, 2020 6:34 am
by ndesktop
The Chromium issue 1078903 looks related.
Especially the last comment
"Screen Enumeration blocking issues also block Window Placement"
which relates to the Electron fix.
The fix, not surprisingly, guards the SetWindowPlacement call with a boolean (block_chromium_message_handler_) so the WNDPROC would call just DefWindowProc and not do something else.

My opinion is the error in that code is calling SetWindowPlacement from inside the WM_GETMINMAXINFO message handling.
WM_GETMINMAXINFO: "Sent to a window when the size or position of the window is about to change."
Well bad luck, we just called SetWindowPlacement and lied to the caller.