CefClient + tab support

[Peter]

Hmm, I wonder if it is possible to use JavaScript to restore the navigation entries, using something like "pushState"?

[magreenblatt]

Hmm, I wonder if it is possible to use JavaScript to restore the navigation entries, using something like "pushState"?

Yes, possibly.

[Peter]

No luck with navigation, but perhaps you could help me with another tab-related problem I'm having.

I added a GTK notebook to the CEFClient example for tabs, and I show/hide the CEF browsers using X(Un)MapWindow (this I had to add because otherwise they did not hide) - but apparently I have a problem with input focus not focusing properly on browser windows.

I am calling GetHost()->SetFocus(), but somehow it does not always work, and as a result context menu stops showing up - and only if I click outside the window and inside again makes it work reliably.
This might be related to my (lack of) understanding of GTK, but maybe you could give me an advice on where to look for what's causing it...

[Peter]

Or rather, the question is:
Can I safely replace`SetXWindowVisible()` from browser_window_std_gtk.cc that looks like this:

Code: Select all

void SetXWindowVisible(::Window xwindow, bool visible) {
  ::Display* xdisplay = cef_get_xdisplay();

  // Retrieve the atoms required by the below XChangeProperty call.
  const char* kAtoms[] = {"_NET_WM_STATE", "ATOM", "_NET_WM_STATE_HIDDEN"};
  Atom atoms[3];
  int result =
      XInternAtoms(xdisplay, const_cast<char**>(kAtoms), 3, false, atoms);
  if (!result)
    NOTREACHED();

  if (!visible) {
    // Set the hidden property state value.
    scoped_ptr<Atom[]> data(new Atom[1]);
    data[0] = atoms[2];

    XChangeProperty(xdisplay, xwindow,
                    atoms[0],  // name
                    atoms[1],  // type
                    32,        // size in bits of items in 'value'
                    PropModeReplace,
                    reinterpret_cast<const unsigned char*>(data.get()),
                    1);  // num items
  } else {
    // Set an empty array of property state values.
    XChangeProperty(xdisplay, xwindow,
                    atoms[0],  // name
                    atoms[1],  // type
                    32,        // size in bits of items in 'value'
                    PropModeReplace, NULL,
                    0);  // num items
  }
}

with this:

Code: Select all

void SetXWindowVisible(::Window xwindow, bool visible) {
  ::Display* xdisplay = cef_get_xdisplay();

  if (!visible)
    XUnmapWindow(xdisplay, xwindow);
  else
    XMapWindow(xdisplay, xwindow);
}

[magreenblatt]

Or rather, the question is:
Can I safely replace`SetXWindowVisible()` from browser_window_std_gtk.cc that looks like this:

Sorry, I don't know. I suspect there was some reason we didn't use XUnmapWindow originally, but I don't remember the details.