Version 81 (4044) RegisterCustomSchemes

[ebahar]

Hi,
i notice that in the new CEF version (81),
when adding RegisterCustomSchemes and register custom Scheme
at

Code: Select all

void CefContentClient::AddCustomScheme(const SchemeInfo& scheme_info) {
  DCHECK(!scheme_info_list_locked_);
  scheme_info_list_.push_back(scheme_info);

  if (CefContentBrowserClient::Get()) {
    CefContentBrowserClient::Get()->RegisterCustomScheme(
        scheme_info.scheme_name);
  }
}


CefContentBrowserClient::Get() is always null (create later),

in Cef79 is wasn't like that.
im running with -multi-threaded-message-loop flag.

[ebahar]

from look at content_main_runner_impl.cc,
RegisterContentSchemes()
is now called before:
ContentClientInitializer::Set(process_type, delegate_)
which initialized thecontent::ContentBrowserClient* at CefMainDelegate::CreateContentBrowserClient().

so now:
csutom scheme are not RegisterCustomScheme at:

Code: Select all

void CefContentBrowserClient::RegisterCustomScheme(const std::string& scheme) {
  // Register as a Web-safe scheme so that requests for the scheme from a
  // render process will be allowed in resource_dispatcher_host_impl.cc
  // ShouldServiceRequest.
  content::ChildProcessSecurityPolicy* policy =
      content::ChildProcessSecurityPolicy::GetInstance();
  if (!policy->IsWebSafeScheme(scheme))
    policy->RegisterWebSafeScheme(scheme);
}


and on some cases (when using custom scheme inside other custom scheme) to block to request
because the scheme not mark as IsWebSafeScheme

[magreenblatt]

Please add a bug, and include a reproduction case.