cmake error for c / obj-c files

[sdiverdi]

I've found a bug in the cmake configuration of CEF that makes adding .c and .m files (C and Obj-C respectively) to a project fail to compile in Xcode 12.3. Specifically, this line:
https://bitbucket.org/chromiumembedded/ ... #lines-278

Code: Select all

    -std=gnu++11                    # Use the C++11 language standard including GNU extensions


combined with this line:
https://bitbucket.org/chromiumembedded/ ... #lines-275

Code: Select all

  target_compile_options(${target} PRIVATE ${CEF_COMPILER_FLAGS} ${CEF_CXX_COMPILER_FLAGS})


results in -std=gnu++11 getting added to the Xcode C flags, which causes a compiler error (because gnu++11 is not a valid standard for C or Obj-C). The fix is simple, just remove the line from cef_variables.cmake.in, which removes the flag, which is unnecessary because the language standard for Xcode is set in:
https://bitbucket.org/chromiumembedded/ ... #lines-305

Code: Select all

      XCODE_ATTRIBUTE_CLANG_CXX_LANGUAGE_STANDARD                 "gnu++11"   # -std=gnu++11


Then .c and .m files can be successfully included in a project.

[magreenblatt]

Can you submit a PR for the fix? Thanks.