Page 1 of 1

CreateBrowserSync without Request Context

PostPosted: Thu May 20, 2021 1:07 pm
by Florian
Since this change, CreateBrowserSync no longer accepts an empty value (i.e. nullptr) for the request context.

As code called later still checks for an empty value to use the global request context and the docs still states that it is possible to pass an empty request context, there is a conflict between the code and the docs.

What is the intended behaviour? Passing CefRequestContext::GetGlobalContext() is a workaround.

Re: CreateBrowserSync without Request Context

PostPosted: Thu May 20, 2021 2:05 pm
by magreenblatt
Thanks for posting. This was not an intentional change (you should still be able to pass NULL). I'll fix it shortly.

Re: CreateBrowserSync without Request Context

PostPosted: Thu May 20, 2021 2:20 pm
by magreenblatt
Now fixed. Automated builds with the fix should be available tomorrow.

Re: CreateBrowserSync without Request Context

PostPosted: Thu May 20, 2021 7:52 pm
by Florian
Thanks a lot.