Problem with building branch 4577 in Windows 10

[mulleriguez]

I have a problem with building 4577, the output of create.bat shows:

Code: Select all

Generating CEF project files...
Generating Visual Studio projects took 3610ms
Done. Made 16735 targets from 2856 files in 48057ms
Traceback (most recent call last):
  File "tools\gclient_hook.py", line 146, in <module>
    RunAction(src_dir, cmd)
  File "D:\dep\c93\chromium_git\chromium\src\cef\tools\gclient_util.py", line 36, in RunAction
    command, cwd=dir, always_show_header=True, print_stdout=True)
  File "D:\dep\c93\depot_tools\gclient_utils.py", line 673, in CheckCallAndFilter
    rv, args, kwargs.get('cwd', None), command_output.getvalue(), None)
subprocess2.CalledProcessError: Command 'gn gen out\\Debug_GN_x64 --ide=vs2019 --sln=cef --filters=//cef/*' returned non-zero exit status -1 in D:\dep\c93\chromium_git\chromium\src
Generating Visual Studio projects took 3610ms
Done. Made 16735 targets from 2856 files in 48057ms


run the command ''gn gen out\\Debug_GN_x64 --ide=vs2019 --sln=cef --filters=//cef/*" at chromium/src, then:

Code: Select all

D:\dep\c93\chromium_git\chromium\src>gn gen out\\Debug_GN_x64 --ide=vs2019 --sln=cef --filters=//cef/*
Generating Visual Studio projects took 3374ms
Done. Made 16735 targets from 2856 files in 46780ms
D:\dep\c93\chromium_git\chromium\src>echo %errorlevel%
-1


If adding -v to 'gn gen ...' command, could not find any error or failed or except in log.

Here's more info for any help:
update.bat

Code: Select all

set CEF_USE_GN=1
set GN_DEFINES=is_official_build=true proprietary_codecs=true ffmpeg_branding=Chrome
set GN_ARGUMENTS=--ide=vs2019 --sln=cef --filters=//cef/*
python ..\automate\automate-git.py --download-dir=D:\dep\c93\chromium_git --branch=4577 --depot-tools-dir=D:\dep\c93\depot_tools --no-distrib --no-build --force-clean


create.bat

Code: Select all

set DEPOT_TOOLS_WIN_TOOLCHAIN=0
set CEF_USE_GN=1
set GN_DEFINES=is_official_build=true proprietary_codecs=true ffmpeg_branding=Chrome
set GN_ARGUMENTS=--ide=vs2019 --sln=cef --filters=//cef/*
call cef_create_projects.bat


Environment:
Windows 10 21H1 x64
Visual Studio 2019 Community v16.11.2 with native desktop workload and ATLMFC component
[VS installed to default location: C:\Program Files (x86)\Microsoft Visual Studio\2019]
Windows SDK 10.0.19041
depot_tools in %PATH%

[magreenblatt]

Have you tried building? Does it give any errors?

[mulleriguez]

Have you tried building? Does it give any errors?

Not yet, I read the code of 'cef/tools/gclient.py', after 'gn gen ...', it should run tools/make_config_header.py. But the process stop while then 'gn gen' returns -1.
So... didn't try building.

Should I run the tools/make_config_header.py manually, then try building it?

[magreenblatt]

Yes, that’s a good next step.

[mulleriguez]

Yes, that’s a good next step.

Thanks for your help. Build successfully and support h.264.

I modified the gclient_utils.py to skip the exception raising.