Problem building 4951 branch in Windows 10

[rjxray]

I'm currently trying to build 4951 branch for the first time on Windows 10 version 21H2
I downloaded and installed Windows SDK 10.0.20348
I downloaded and updated depot_tools and set it as the first item in my path.

Then I ran

python automate\automate-git.py --download-dir=D:\CefBuild4951 --depot-tools-dir=D:\CefBuild4951\depot_tools --branch=4951 --x64-build

The build failed

Code: Select all

Running hooks:  30% (37/122) apache_win32
________ running 'python3 src/third_party/depot_tools/download_from_google_storage.py --no_resume --directory --recursive --no_auth --num_threads=16 --bucket chromium-apache-win32 src/third_party/apache-win32' in 'D:\CefBuild4951\chromium'
Access is denied.

Failed to fetch file gs://chromium-apache-win32/50699041060d14576ed7bacbd44be9af80eb902a for src/third_party/apache-win32\bin\api-ms-win-core-processthreads-l1-1-0.dll. [Err: Access is denied.
]
Failed to fetch file gs://chromium-apache-win32/0bffb9ed366853e7019452644d26e8e8f236241b for src/third_party/apache-win32\bin\api-ms-win-core-processthreads-l1-1-1.dll. [Err: Access is denied.
]


followed by many many other similar errors.

I thought it might be a temporary problem with fetching apache-win32 so retried.
This time it ran through to building but then failed again

Code: Select all

--> D:\CefBuild4951\chromium\src\out\Debug_GN_x64\args.gn contents:
chrome_pgo_phase=0
clang_use_chrome_plugins=false
dcheck_always_on=true
enable_background_mode=false
enable_basic_printing=true
enable_nacl=false
enable_print_preview=true
enable_resource_allowlist_generation=false
enable_widevine=true
ffmpeg_branding="Chrome"
is_component_build=false
is_debug=false
is_official_build=true
optimize_webui=true
proprietary_codecs=true
target_cpu="x64"
-------- Running "ninja -C out\Debug_GN_x64 cefclient" in "D:\CefBuild4951\chromium\src"...
ninja: Entering directory `out\Debug_GN_x64'
[420/51741] ACTION //chrome/browser/resources/feed:build_ts(//build/toolchain/win:win_clang_x64)
FAILED: gen/chrome/browser/resources/feed/tsconfig.json gen/chrome/browser/resources/feed/tsconfig.manifest gen/chrome/browser/resources/feed/tsc/feed.js
D:/CefBuild4951/depot_tools/bootstrap-2@3_8_10_chromium_23_bin/python3/bin/python3.exe ../../tools/typescript/ts_library.py --root_dir ../../chrome/browser/resources/feed --gen_dir gen/chrome/browser/resources/feed --out_dir gen/chrome/browser/resources/feed/tsc --in_files feed.ts --path_mappings chrome://resources/*|../../../../ui/webui/resources/preprocessed/* //resources/*|../../../../ui/webui/resources/preprocessed/* chrome://resources/polymer/v3_0/*|../../../../../../../third_party/polymer/v3_0/components-chromium/* //resources/polymer/v3_0/*|../../../../../../../third_party/polymer/v3_0/components-chromium/* chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js|../../../../../../../third_party/polymer/v3_0/components-chromium/polymer/polymer.d.ts //resources/polymer/v3_0/polymer/polymer_bundled.min.js|../../../../../../../third_party/polymer/v3_0/components-chromium/polymer/polymer.d.ts /tools/typescript/definitions/*|../../../../../../../tools/typescript/definitions/*
Traceback (most recent call last):
  File "../../tools/typescript/ts_library.py", line 153, in <module>
    main(sys.argv[1:])
  File "../../tools/typescript/ts_library.py", line 117, in main
    node.RunNode([
  File "D:\CefBuild4951\chromium\src\out\Debug_GN_x64\..\..\third_party\node\node.py", line 25, in RunNode
    process = subprocess.Popen(
  File "D:\CefBuild4951\depot_tools\bootstrap-2@3_8_10_chromium_23_bin\python3\bin\lib\subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "D:\CefBuild4951\depot_tools\bootstrap-2@3_8_10_chromium_23_bin\python3\bin\lib\subprocess.py", line 1311, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] The system cannot find the file specified
[433/51741] ACTION //chrome/browser/resources/download_she...rocess_web_components(//build/toolchain/win:win_clang_x64)
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
  File "automate\automate-git.py", line 1485, in <module>
    if options.buildlogfile else None)
  File "automate\automate-git.py", line 70, in run
    args, cwd=working_dir, env=env, shell=(sys.platform == 'win32'))
  File "D:\CefBuild4951\depot_tools\bootstrap-2@3_8_10_chromium_23_bin\python\bin\lib\subprocess.py", line 190, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['ninja', '-C', 'out\\Debug_GN_x64', 'cefclient']' returned non-zero exit status 1


I was unsure whether rerunning automate-git would have correctly fetched apache-win32 so two days later I deleted my entire CefBuild4951 hierarchy and tried again from scratch with exactly the same results.

I tried googling for issues fetching apache-win32 and didn't turn up anything

I compared my new D:\CefBuild4951\chromium\src\third_party\apache-win32\bin folder with my previous 4638 build and saw that it does not have the dlls that the previous one has, only the sha1 files so it appears that may be the problem.

Any ideas or suggestions?

[FriwiDev]

It appears that the bucket folder the script is trying to use is empty: https://console.cloud.google.com/storag ... af80eb902a

[rjxray]

Yesterday I thought I may as well try again whilst my work PC was doing nothing else.
This time it ran through and successfully built Debug_GN_x64 and Debug_GN_x64_sandbox and was continuing to do the release builds.
I killed that because I need to do some patches before a full build.
Before doing that I tried running cefclient.exe in chromium\src\out\Debug_GN_x64 and it just showed an hourglass for a second or two and then returned to the command prompt
I tried again with the --no-sandbox argument and again it didn't run but this time it created debug.log with this content

Code: Select all

[0502/102050.232:INFO:content_main_runner_impl.cc(1173)] Chrome is running in full browser mode.
[0502/102054.358:ERROR:broker_win.cc(56)] Error reading broker pipe: The pipe has been ended. (0x6D)


I loaded cef.sln and ran it with the debugger
It crashed in libcef.dll!logging::RawLog()
call stack was

Code: Select all

>   libcef.dll!logging::RawLog(int level, const char * message) Line 1142   C++
    [Inline Frame] libcef.dll!partition_alloc::internal::PartitionAddressSpace::GetPoolAndOffset(unsigned __int64 address) Line 84   C++
    [Inline Frame] libcef.dll!partition_alloc::internal::GetPoolAndOffset(unsigned __int64 address) Line 289   C++
    [Inline Frame] libcef.dll!partition_alloc::internal::ReservationOffsetPointer(unsigned __int64 address) Line 145   C++
    [Inline Frame] libcef.dll!partition_alloc::internal::IsReservationStart(unsigned __int64 address) Line 223   C++
    [Inline Frame] libcef.dll!base::PartitionRoot<1>::FromAddrInFirstSuperpage(unsigned __int64 address) Line 1380   C++
    [Inline Frame] libcef.dll!base::PartitionRoot<1>::FreeNoHooks(void * object) Line 1090   C++
    libcef.dll!base::internal::PartitionFree(const base::allocator::AllocatorDispatch *, void * object, void * context) Line 421   C++
    [Inline Frame] libcef.dll!scoped_refptr<sandbox::TargetPolicy>::Release(sandbox::TargetPolicy * ptr) Line 321   C++
    [Inline Frame] libcef.dll!scoped_refptr<sandbox::TargetPolicy>::~scoped_refptr() Line 223   C++
    libcef.dll!sandbox::policy::SandboxWin::StartSandboxedProcess(const base::CommandLine & cmd_line, const std::__1::basic_string<char,std::__1::char_traits<char>,std::__1::allocator<char>> & process_type, const std::__1::vector<void *,std::__1::allocator<void *>> & handles_to_inherit, sandbox::policy::SandboxDelegate * delegate, base::Process * process) Line 1220   C++
    libcef.dll!content::StartSandboxedProcess(content::SandboxedProcessLauncherDelegate * delegate, const base::CommandLine & target_command_line, const std::__1::vector<void *,std::__1::allocator<void *>> & handles_to_inherit, base::Process * process) Line 46   C++
    libcef.dll!content::internal::ChildProcessLauncherHelper::LaunchProcessOnLauncherThread(const base::LaunchOptions & options, std::__1::unique_ptr<std::__1::vector<void *,std::__1::allocator<void *>>,std::__1::default_delete<std::__1::vector<void *,std::__1::allocator<void *>>>> files_to_register, bool * is_synchronous_launch, int * launch_result) Line 82   C++
    libcef.dll!content::internal::ChildProcessLauncherHelper::LaunchOnLauncherThread() Line 142   C++
    [Inline Frame] libcef.dll!base::OnceCallback<void ()>::Run() Line 142   C++
    libcef.dll!base::TaskAnnotator::RunTaskImpl(base::PendingTask & pending_task) Line 135   C++
    [Inline Frame] libcef.dll!base::TaskAnnotator::RunTask(perfetto::StaticString event_name, base::PendingTask & pending_task, base::internal::TaskTracker::RunTaskImpl::<lambda_0> && args) Line 74   C++
    libcef.dll!base::internal::TaskTracker::RunTaskImpl(base::internal::Task & task, const base::TaskTraits & traits, base::internal::TaskSource * task_source, const base::SequenceToken & token) Line 708   C++
    libcef.dll!base::internal::TaskTracker::RunBlockShutdown(base::internal::Task & task, const base::TaskTraits & traits, base::internal::TaskSource * task_source, const base::SequenceToken & token) Line 701   C++
    [Inline Frame] libcef.dll!base::internal::TaskTracker::RunTaskWithShutdownBehavior(base::internal::Task & task, const base::TaskTraits & traits, base::internal::TaskSource * task_source, const base::SequenceToken & token) Line 726   C++
    libcef.dll!base::internal::TaskTracker::RunTask(base::internal::Task task, base::internal::TaskSource * task_source, const base::TaskTraits & traits) Line 550   C++
    libcef.dll!base::internal::TaskTracker::RunAndPopNextTask(base::internal::RegisteredTaskSource task_source) Line 470   C++
    libcef.dll!base::internal::WorkerThread::RunWorker() Line 381   C++
    libcef.dll!base::internal::WorkerThread::RunDedicatedWorker() Line 289   C++
    libcef.dll!base::`anonymous namespace'::ThreadFunc(void * params) Line 114   C++


[magreenblatt]

I downloaded and installed Windows SDK 10.0.20348

4951 branch requires the 10.0.19041 SDK. See https://bitbucket.org/chromiumembedded/ ... -supported

[rjxray]

Yes, I realised that later and double checked, I found I already had 10.0.19041.685 installed. Does it matter that I also installed the later one?

[magreenblatt]

Yes, I realised that later and double checked, I found I already had 10.0.19041.685 installed. Does it matter that I also installed the later one?

Nope, it should be fine (the build should select the required version). You can check the paths in your out\Debug_GN_x64\environment.x64 file to verify.

[rjxray]

I found the entry "C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\winrt; " in out/environment.x64 so its seems that's ok.
Can you think of any other possible cause for the issue?

Meanwhile I had renamed out to out1, checked d:/CefBuild4951/depot _tools was the first item in my path, checked GN_DEFINES=is_official_build=true proprietary_codecs=true ffmpeg_branding=Chrome, checked GN_ARGS=--ide=vs2019 --sln=cef --filters=//cef/* then ran cef_create_projects then ran ninja -C out\Debug_GN_x64 cefclient which is currently on 12484/51741.

I'm also running a full automate-git on a more powerful remote development machine in parallel.

I'll check the results in the morning (UK time)

PS, I had also uninstalled the 10.0.20348 SDK

[magreenblatt]

Does the sandbox problem reproduce with the official builds of 4951?

[rjxray]

The build on the remote server has just completed.
Running cefclient behaves as before, without the --no-sandbox option debug.log is created but empty.
with the --no-sandbox argument I very briefly see the client window and these lines are written to it

Code: Select all

[0502/214551.346:INFO:content_main_runner_impl.cc(1173)] Chrome is running in full browser mode.
[0502/214554.115:ERROR:broker_win.cc(56)] Error reading broker pipe: The pipe has been ended. (0x6D)


I'll check the official build in the morning

[rjxray]

I downloaded and ran cef_binary_101.0.13+g485fa78+chromium-101.0.4951.41_windows64_beta_client It worked OK.
That gave me another idea, I tried running cefclient from out\Release_GN_x64 on my remote server build. That also worked OK.
So the issue is only with the debug build

Next I downloaded and built the full cef_binary_101.0.13+g485fa78+chromium-101.0.4951.41_windows64_beta. A debug build of cefclient works OK
So the issue is only with my full cef/chromium debug build

I ' trying doing a build without the proprietary codecs as that is the obvious difference for my build.
I changed GN_DEFINES to just "is_official_build=true"
Leaving it blank didn't work as when running cef_create_projects I got

Code: Select all

ERROR at //build/config/compiler/compiler.gni:315:3: Assertion failed.
Can't do non-component debug builds at symbol_level=2 without use_debug_fission=true


the build has failed

Code: Select all

[51081/51572] LINK v8_context_snapshot_generator.exe v8_context_snapshot_generator.exe.pdb
FAILED: v8_context_snapshot_generator.exe v8_context_snapshot_generator.exe.pdb
..\..\third_party\llvm-build\Release+Asserts\bin\lld-link.exe /OUT:./v8_context_snapshot_generator.exe /nologo -libpath:..\..\third_party\llvm-build\Release+Asserts\lib\clang\15.0.0\lib\windows "-libpath:C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.29.30037\ATLMFC\lib\x64" "-libpath:C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.29.30037\lib\x64" "-libpath:C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\lib\um\x64" "-libpath:C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\ucrt\x64" "-libpath:C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\um\x64" /MACHINE:X64  /PDB:./v8_context_snapshot_generator.exe.pdb @./v8_context_snapshot_generator.exe.rsp
LLVM ERROR: IO failure on output stream: no space on device
PLEASE submit a bug report to https://crbug.com and run tools/clang/scripts/process_crashreports.py (only works inside Google) which will upload a report and include the crash backtrace.
Stack dump:
0.      Program arguments: ..\\..\\third_party\\llvm-build\\Release+Asserts\\bin\\lld-link.exe /OUT:./v8_context_snapshot_generator.exe /nologo -libpath:..\\..\\third_party\\llvm-build\\Release+Asserts\\lib\\clang\\15.0.0\\lib\\windows "-libpath:C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Professional\\VC\\Tools\\MSVC\\14.29.30037\\ATLMFC\\lib\\x64" "-libpath:C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Professional\\VC\\Tools\\MSVC\\14.29.30037\\lib\\x64" "-libpath:C:\\Program Files (x86)\\Windows Kits\\NETFXSDK\\4.8\\lib\\um\\x64" "-libpath:C:\\Program Files (x86)\\Windows Kits\\10\\lib\\10.0.19041.0\\ucrt\\x64" "-libpath:C:\\Program Files (x86)\\Windows Kits\\10\\lib\\10.0.19041.0\\um\\x64" /MACHINE:X64 /PDB:./v8_context_snapshot_generator.exe.pdb @./v8_context_snapshot_generator.exe.rsp
 #0 0x00007ff75250af16 (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0xecaf16)
 #1 0x00007ff7523e4e97 (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0xda4e97)
 #2 0x00007ff7523dbb44 (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0xd9bb44)
 #3 0x00007ff752507291 (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0xec7291)
 #4 0x00007ff7519e5460 (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0x3a5460)
 #5 0x00007ff751f65dcd (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0x925dcd)
 #6 0x00007ff75201deba (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0x9ddeba)
 #7 0x00007ff751f41594 (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0x901594)
 #8 0x00007ff751d918d8 (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0x7518d8)
 #9 0x00007ff751d88430 (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0x748430)
#10 0x00007ff751cf7479 (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0x6b7479)
#11 0x00007ff751ce68d1 (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0x6a68d1)
#12 0x00007ff751cdb471 (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0x69b471)
#13 0x00007ff751cdab0f (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0x69ab0f)
#14 0x00007ff7523c9100 (D:\development\Cef\CefBuild4951\chromium\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe+0xd89100)
#15 0x00007ffe67ce7034 (C:\Windows\System32\KERNEL32.DLL+0x17034)
#16 0x00007ffe69022651 (C:\Windows\SYSTEM32\ntdll.dll+0x52651)
ninja: build stopped: subcommand failed.


Should I be using different GN_DEFINES ?