tests\cefsimple not existing in minimal distribution?

Having problems with building or using CEF's C/C++ APIs? This forum is here to help. Please do not post bug reports or feature requests here.

tests\cefsimple not existing in minimal distribution?

Postby linuxcef9 » Mon Sep 12, 2022 11:38 pm

Hello,

I was trying to build CEF based off branch 5429 on windows. The build was successful after which, I wanted to create a distribution. So I ran

make_distrib.bat --ninja-build --minimal --no-docs --distrib-subdir=product

The script creates distribution under binary_distrib folder. I printed out contents of that folder : https://pastebin.com/PjvpnVtk

Next, I created build folder inside binary_distrib/product_minimal/ and ran

CMAKE -G Ninja -DCMAKE_BUILD_TYPE=Release

but I got below errors:

Code: Select all
           
         CMake Error at CMakeLists.txt:226 (add_subdirectory):
           add_subdirectory given source "tests/cefsimple" which is not an existing
           directory.


         CMake Error at CMakeLists.txt:227 (add_subdirectory):
           add_subdirectory given source "tests/gtest" which is not an existing
           directory.


         CMake Error at CMakeLists.txt:228 (add_subdirectory):
           The source directory

            D:/corebuild/build/chromium_git/chromium/src/cef/binary_distrib/product_minimal/tests/ceftests

           does not contain a CMakeLists.txt file.



From pastebin output, you can see that tests/cefsimple folder isn't being created.

The same logic worked fine for branch 5060. So I am unsure what needs to be changed. I compared make_distrib.py and automate-git.py against old version and only changes are related to DOXYGEN. Can you tell me what's missing?

Thanks!
linuxcef9
Expert
 
Posts: 143
Joined: Tue Nov 06, 2018 3:08 pm

Re: tests\cefsimple not existing in minimal distribution?

Postby magreenblatt » Tue Sep 13, 2022 8:27 am

Remove the “--minimal” flag. The minimal distribution does not include sample apps.
magreenblatt
Site Admin
 
Posts: 12383
Joined: Fri May 29, 2009 6:57 pm

Re: tests\cefsimple not existing in minimal distribution?

Postby linuxcef9 » Tue Sep 13, 2022 11:54 am

Remove the “--minimal” flag. The minimal distribution does not include sample apps.


Thanks!
Was the behavior changed recently? Because sample apps were included with --minimal flag in branch 5060.
I tried looking for the commit too but wasn't able to find the change.
linuxcef9
Expert
 
Posts: 143
Joined: Tue Nov 06, 2018 3:08 pm

Re: tests\cefsimple not existing in minimal distribution?

Postby magreenblatt » Tue Sep 13, 2022 2:08 pm

linuxcef9 wrote:
Remove the “--minimal” flag. The minimal distribution does not include sample apps.


Thanks!
Was the behavior changed recently? Because sample apps were included with --minimal flag in branch 5060.
I tried looking for the commit too but wasn't able to find the change.

I don't think so. If you download the minimal distribution it does not contain sample apps.
magreenblatt
Site Admin
 
Posts: 12383
Joined: Fri May 29, 2009 6:57 pm

Re: tests\cefsimple not existing in minimal distribution?

Postby linuxcef9 » Tue Sep 13, 2022 3:28 pm

I don't think so. If you download the minimal distribution it does not contain sample apps.


Yeah true. I just need to build libcef_dll_wrapper again so that's why I use --minimal flag.
Here's what I found :

In 5060 branch, with --minimal flag, D:/corebuild/build/chromium_git/chromium/src/cef/binary_distrib/product_minimal/tests directory is NOT created.
So this condition https://bitbucket.org/chromiumembedded/ ... #lines-225 is false and everything works as expected.

In 5249 branch, with --minimal flag, D:/corebuild/build/chromium_git/chromium/src/cef/binary_distrib/product_minimal/tests/ceftests is created (not sure why).
So the same condition https://bitbucket.org/chromiumembedded/ ... #lines-225 is true, and it tries to add cefsimple and gtest directory subdirectory as well and since those don't exist in minimal distribution, it fails. https://pastebin.com/PjvpnVtk is file structure as I mentioned in my first comment.

Can you help determine what causes tests/ceftests directory to be created in 5249 branch? From make_distrib.py, it is created only when mode == "standard" and since the folder is "product_minimal" , it implies cef did have "minimal" variable set.
Let me know if you need any other information.

Thanks again!
linuxcef9
Expert
 
Posts: 143
Joined: Tue Nov 06, 2018 3:08 pm

Re: tests\cefsimple not existing in minimal distribution?

Postby magreenblatt » Tue Sep 13, 2022 3:49 pm

Can you help determine what causes tests/ceftests directory to be created in 5249 branch?

That appears to be a bug resulting from changes in https://bitbucket.org/chromiumembedded/ ... t-63950740
magreenblatt
Site Admin
 
Posts: 12383
Joined: Fri May 29, 2009 6:57 pm

Re: tests\cefsimple not existing in minimal distribution?

Postby linuxcef9 » Wed Sep 14, 2022 4:17 pm

That appears to be a bug resulting from changes in https://bitbucket.org/chromiumembedded/ ... t-63950740


Will you be fixing this on 5249 branch soon? For now, as a workaround, I just remove the tests directory if it exists, after make_distrib is run.
linuxcef9
Expert
 
Posts: 143
Joined: Tue Nov 06, 2018 3:08 pm

Re: tests\cefsimple not existing in minimal distribution?

Postby magreenblatt » Wed Sep 14, 2022 6:48 pm

Please add a bug so this doesn’t get forgotten.
magreenblatt
Site Admin
 
Posts: 12383
Joined: Fri May 29, 2009 6:57 pm


Return to Support Forum

Who is online

Users browsing this forum: Google [Bot] and 51 guests