magreenblatt wrote:You can fork the CEF repository, commit your patch file, and then build your fork using the automated method. See command-line arguments supported by automate-git.py.
Thanks for that advice.
I went ahead and forked the repo and tried two strategies:
1. Modifying the 5672 branch
2. Using a custom branch
I then proceed by doing the following:
1. Set variables
- Code: Select all
export PATH=/Users/embucksh/code/depot_tools:$PATH
export GN_DEFINES='proprietary_codecs=true ffmpeg_branding="Chrome" is_official_build=true'
export GN_ARGUMENTS='--ide=vs2019 --sln=cef --filters=//cef/*'
2. Run command
- Code: Select all
python3 automate-git.py --download-dir=/Users/embucksh/code/chromium_git --branch=5672 --url=https://github.com/RibbonCommunications/distant-cef.git --minimal-distrib --client-distrib --force-clean --x64-build --with-pgo-profiles
(alternatively, I use --checkout=<custom branch>
In each case, after the automate script checks out and clones third party libraries, I come to the following result:
- Code: Select all
Error: 85> Wrong keys 'git_dependencies' in {'vars': {'boringssl_git': 'https://boringssl.googlesource.com', 'chromium_git': 'https://chromium.googlesource.com', 'quiche_git': 'https://quiche.googlesource.com', 'github': 'https://github.com', 'build_with_chromium': False, 'checkout_clang_coverage_tools': True, 'gn_version': 'git_revision:5e19d2fb166fbd4f6f32147fbb2f497091a54ad8', 'clang_format_revision': 'e435ad79c17b1888b34df88d6a30a094936e3836', 'SUBMODULE_MIGRATION': 'True'}, 'use_relative_paths': True, 'git_dependencies': 'SYNC', 'deps': {'buildtools': {'url': 'https://chromium.googlesource.com/chromium/src/buildtools@3c7e3f1b8b1e4c0b6ec693430379cea682de78d6', 'condition': 'not build_with_chromium'}, 'third_party/clang-format/script': {'url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git@e5337933f2951cacd3aeacd238ce4578163ca0b9', 'condition': 'not build_with_chromium'}, 'buildtools/linux64': {'packages': [{'package': 'gn/gn/linux-amd64', 'version': 'git_revision:811d332bd90551342c5cbd39e133aa276022d7f8'}], 'dep_type': 'cipd', 'condition': 'host_os == "linux" and not build_with_chromium'}, 'buildtools/mac': {'packages': [{'package': 'gn/gn/mac-${arch}', 'version': 'git_revision:811d332bd90551342c5cbd39e133aa276022d7f8'}], 'dep_type': 'cipd', 'condition': 'host_os == "mac" and not build_with_chromium'}, 'third_party/ninja': {'packages': [{'package': 'infra/3pp/tools/ninja/${platform}', 'version': 'version:2@1.8.2.chromium.3'}], 'dep_type': 'cipd', 'condition': 'not build_with_chromium'}, 'third_party/protobuf/src': {'url': 'https://chromium.googlesource.com/external/github.com/protocolbuffers/protobuf.git@909a0f36a10075c4b4bc70fdee2c7e32dd612a72', 'condition': 'not build_with_chromium'}, 'third_party/libprotobuf-mutator/src': {'url': 'https://chromium.googlesource.com/external/github.com/google/libprotobuf-mutator.git@a304ec48dcf15d942607032151f7e9ee504b5dcf', 'condition': 'not build_with_chromium'}, 'third_party/zlib/src': {'url': 'https://github.com/madler/zlib.git@04f42ceca40f73e2978b50e93806c2a18c1281fc', 'condition': 'not build_with_chromium'}, 'third_party/jsoncpp/src': {'url': 'https://chromium.googlesource.com/external/github.com/open-source-parsers/jsoncpp.git@5defb4ed1a4293b8e2bf641e16b156fb9de498cc', 'condition': 'not build_with_chromium'}, 'third_party/googletest/src': {'url': 'https://chromium.googlesource.com/external/github.com/google/googletest.git@b495f72f1f096135cf9cf8c7879b5b89250de50a', 'condition': 'not build_with_chromium'}, 'third_party/boringssl/src': {'url': 'https://boringssl.googlesource.com/boringssl.git@51ed32f1971956a904ce7b3a7ff10716e76eecd4', 'condition': 'not build_with_chromium'}, 'third_party/quiche/src': {'url': 'https://quiche.googlesource.com/quiche.git@7b58beaec1f65b8e074ddb81796e34f3d6d83cf3', 'condition': 'not build_with_chromium'}, 'third_party/tinycbor/src': 'https://chromium.googlesource.com/external/github.com/intel/tinycbor.git@d393c16f3eb30d0c47e6f9d92db62272f0ec4dc7', 'third_party/abseil/src': {'url': 'https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp.git@78be63686ba732b25052be15f8d6dee891c05749', 'condition': 'not build_with_chromium'}, 'third_party/libfuzzer/src': {'url': 'https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git@debe7d2d1982e540fbd6bd78604bf001753f9e74', 'condition': 'not build_with_chromium'}, 'third_party/modp_b64': {'url': 'https://chromium.googlesource.com/chromium/src/third_party/modp_b64@3643752c065d984647f0ded68a9a01926fb3b9cd', 'condition': 'not build_with_chromium'}, 'third_party/valijson/src': {'url': 'https://github.com/tristanpenman/valijson.git@78ac8a737df56b5334354efe104ea8f99e2a2f00', 'condition': 'not build_with_chromium'}}, 'hooks': [{'name': 'clang_update_script', 'pattern': '.', 'condition': 'not build_with_chromium', 'action': ['tools/download-clang-update-script.py', '--output', 'tools/clang/scripts/update.py']}, {'name': 'update_clang', 'pattern': '.', 'condition': 'not build_with_chromium', 'action': ['python3', 'tools/clang/scripts/update.py']}, {'name': 'clang_coverage_tools', 'pattern': '.', 'condition': 'not build_with_chromium and checkout_clang_coverage_tools', 'action': ['python3', 'tools/clang/scripts/update.py', '--package=coverage_tools']}, {'name': 'clang_format_linux64', 'pattern': '.', 'action': ['download_from_google_storage.py', '--no_resume', '--no_auth', '--bucket', 'chromium-clang-format', '-s', 'buildtools/linux64/clang-format.sha1'], 'condition': 'host_os == "linux" and not build_with_chromium'}, {'name': 'clang_format_mac_x64', 'pattern': '.', 'action': ['download_from_google_storage.py', '--no_resume', '--no_auth', '--bucket', 'chromium-clang-format', '-s', 'buildtools/mac/clang-format.x64.sha1'], 'condition': 'host_os == "mac" and host_cpu == "x64" and not build_with_chromium'}, {'name': 'clang_format_mac_arm64', 'pattern': '.', 'action': ['download_from_google_storage.py', '--no_resume', '--no_auth', '--bucket', 'chromium-clang-format', '-s', 'buildtools/mac/clang-format.arm64.sha1'], 'condition': 'host_os == "mac" and host_cpu == "arm64" and not build_with_chromium'}], 'include_rules': ['+util', '+platform/api', '+platform/base', '+platform/test', '+testing/util', '+third_party', '-discovery', '+discovery/common', '+discovery/dnssd/public', '+discovery/mdns/public', '+discovery/public', '-third_party/abseil', '+absl/algorithm/container.h', '+absl/base/thread_annotations.h', '+absl/hash/hash.h', '+absl/hash/hash_testing.h', '+absl/strings/ascii.h', '+absl/strings/match.h', '+absl/strings/numbers.h', '+absl/strings/str_cat.h', '+absl/strings/str_join.h', '+absl/strings/str_replace.h', '+absl/strings/str_split.h', '+absl/strings/string_view.h', '+absl/strings/substitute.h', '+absl/types/optional.h', '+absl/types/span.h', '+absl/types/variant.h', '-third_party/boringssl', '-third_party/googletest', '+gtest', '+gmock']}
Have you any idea what this could be?