5790 compilation fails on windows due to ANGLE lib

[linuxcef9]

Hello team,

I am building CEF from source on windows using automated method for release branch 5790 (115.0.5790.114) using below command:

Code: Select all

python ..\automate\automate-git.py --no-depot-tools-update --download-dir=%CHROMIUM_GIT_DIR% --depot-tools-dir=%DEPOT_TOOLS_DIR% --force-clean --no-distrib --no-build --branch=5790 --chromium-checkout=refs/tags/115.0.5790.114 --verbose-build --checkout=a61da9b80ccf384ac214050fe75f3923e7703d4f --with-pgo-profiles

But the compilation is failing with below error:

../../third_party/angle/src/common/angle_version_info.cpp(15,5): error: non-void function 'GetANGLERevision' should return a value [-Wreturn-type]
return ANGLE_REVISION;

Automate-git script is doing code check-out and compilation of chromium.
And the code which is failing, belongs to ANGLE lib, which is third party dependency of chromium.
https://source.chromium.org/chromium/chromium/src/+/main:third_party/angle/src/common/angle_version_info.cpp;l=13?q=GetAngleRevision&ss=chromium
So I cannot make any changes in angle/chromium.

I am using below windows build environment:

Win 2016 cpu:28, mem:42.0039GB, disk:500GB
VS2022 17.5+, MSVC/14.36.32532
Win 10.0.22621.0 SDK, Ninja

Am I missing anything here?
Can someone help me with the fix for this issue?

[magreenblatt]

Did the checkout and "gclient sync" steps succeed without error?

[linuxcef9]

Yes, there was no issue with checkout and gclient sync but later build cef is failing.

Command '['ninja', '-v', '-C', 'out\\Release_GN_x86', 'cef']' returned non-zero exit status 1

[magreenblatt]

Did “ third_party/angle/src” get checked out to the correct revision, as listed in the chromium DEPS file?

[linuxcef9]

Yes, the "third_party/angle/src” get checked out to the correct revision, as listed in the chromium DEPS file.

On further analysis, ANGLE_REVISION macro is dependent on ANGLE_COMMIT_POSITION macro which is generated by the python file here : https://chromium.googlesource.com/angle ... _id.py#129

but we are not sure who invokes this file.
also, angle_commit.h is missing in our local environment.
Can you help with this?

[linuxcef9]

On further analysis, found that BUILD.gn has action to invoke command_id.py : https://source.chromium.org/chromium/ch ... 2Fangle%2F

Which step in CEF build process would invoke this BUILD.gn file?

[magreenblatt]

Via ninja build probably. You can use the gn path command to analyze target dependencies.

[linuxcef9]

Via ninja build probably. You can use the gn path command to analyze target dependencies.

Okay I see, thank you. Before I run ninja command, I remove .git directories so that source code size on disk is minimized. I'll exclude angle folder from that to see if that helps.
But surprisingly, even for 5481 version, I removed .git directories and build succeeded even though BUILD.gn of 5481 version invoked command_id.py