Should I expect the CEF 5993 (v118) branch to build ?

[callum]

Should I expect the CEF 5993 (v118) branch to build currently? My desktop Chrome updated to 1118 this morning so I thought it would be worth trying to build CEF 118 too. The Windows 64 build fails with this error which smells like a Python 2/3 issue (macOS version takes 10 hours but looks like it will build okay):

Code: Select all

________ running 'python3 src/v8/tools/builtins-pgo/download_profiles.py download --depot-tools src/third_party/depot_tools' in 'C:\cef\5993_64\chromium_git\chromium'
________ running 'python3 src/testing/generate_location_tags.py --out src/testing/location_tags.json' in 'C:\cef\5993_64\chromium_git\chromium'
________ running 'python3 src/build/del_ninja_deps_cache.py' in 'C:\cef\5993_64\chromium_git\chromium'
________ running 'python3 src/third_party/depot_tools/download_from_google_storage.py --no_auth --quiet --bucket chromium-style-perftest -d src/third_party/blink/renderer/core/css/perftest_data' in 'C:\cef\5993_64\chromium_git\chromium'
Hook 'python3 src/third_party/depot_tools/download_from_google_storage.py --no_auth --quiet --bucket chromium-style-perftest -d src/third_party/blink/renderer/core/css/perftest_data' took 14.85 secs
________ running 'python3 src/build/config/siso/configure_siso.py --rbe_instance projects/rbe-chrome-untrusted/instances/default_instance' in 'C:\cef\5993_64\chromium_git\chromium'
Traceback (most recent call last):
  File "C:\cef\5993_64\chromium_git\chromium\src\cef\tools\gclient_hook.py", line 9, in <module>
    from gclient_util import *
  File "C:\cef\5993_64\chromium_git\chromium\src\cef\tools\gclient_util.py", line 28, in <module>
    import gclient_utils
  File "C:\cef\5993_64\depot_tools\gclient_utils.py", line 74
    print('\n\nWarnings:', file=sys.stderr)
                               ^
SyntaxError: invalid syntax


I can build 117 (5938) on all platforms and I don't see any new build requirements in the "Branches and Building" page that I use for reference.

What am I missing?

[magreenblatt]

Automated builders seem fine: https://cef-builds.spotifycdn.com/index.html

[magreenblatt]

Is your depot_tools checkout at the correct revision?

[callum]

> Is your depot_tools checkout at the correct revision?

Looks like my script downloads depot tools from "https://storage.googleapis.com/chrome-infra/depot_tools.zip" unpacks it then runs update_depot_tools.bat to update itself.

Was there a change post v117 which means that approach is no longer valid?

[callum]

I didn't see this in the GitHub Actions log but when I try to download and update depot tools manually I see:

Code: Select all

> update_depot_tools.bat
Updating depot_tools...
Downloading CIPD client for windows-amd64 from https://chrome-infra-packages.appspot.com/client?platform=windows-amd64&version=git_revision:6e9be28a4c4e3a804f400dc6c2ed08b866f0a38b...
Traceback (most recent call last):
  File "C:\Users\callum\Desktop\depot_tools\\.cipd_bin\goma_ctl.py", line 2385, in <module>
    sys.exit(main())
  File "C:\Users\callum\Desktop\depot_tools\\.cipd_bin\goma_ctl.py", line 2379, in main
    goma = GetGomaDriver()
  File "C:\Users\callum\Desktop\depot_tools\\.cipd_bin\goma_ctl.py", line 2375, in GetGomaDriver
    return GomaDriver(env)
  File "C:\Users\callum\Desktop\depot_tools\\.cipd_bin\goma_ctl.py", line 532, in __init__
    self._env.GetGomaTmpDir())
  File "C:\Users\callum\Desktop\depot_tools\\.cipd_bin\goma_ctl.py", line 1501, in GetGomaTmpDir
    self._goma_tmp_dir = _CheckOutput([self._gomacc_binary, 'tmp_dir'],
  File "C:\Users\callum\Desktop\depot_tools\\.cipd_bin\goma_ctl.py", line 416, in _CheckOutput
    return PopenWithCheck(args,
  File "C:\Users\callum\Desktop\depot_tools\\.cipd_bin\goma_ctl.py", line 403, in communicate
    raise CalledProcessError(
__main__.CalledProcessError: Command returned non-zero exit status 3221226505

[magreenblatt]

See viewtopic.php?f=6&t=19537&p=53995#p54004 as a possible solution for the goma_ctl.py error.

[magreenblatt]

Looks like my script downloads depot tools from "https://storage.googleapis.com/chrome-infra/depot_tools.zip" unpacks it then runs update_depot_tools.bat to update itself.

The automate-git.py script clones the depot_tools repo by default on MacOS and Linux. You might want to try that instead of the zip download.

[callum]

See viewtopic.php?f=6&t=19537&p=53995#p54004 as a possible solution for the goma_ctl.py error.

That explains why the auto-builders are working okay - I am building with codec support turned on.

Looks like there are some useful tips in that forum post that I can try - thank you Marshall.

[callum]

The automate-git.py script clones the depot_tools repo by default on MacOS and Linux. You might want to try that instead of the zip download.

Yep - the macOS one looks to be building okay and should finish in a couple of hours.

[callum]

None of the suggestions in that thread helped.

I also tried 117 builds both locally and in GitHub Actions and they completed normally.