Build 6099 fails

[delphirules]

Hello,

Last night i tried to build branch 6099 but it fails with the errors below. Any ideas please ?

-------- Running "ninja -C out\Debug_GN_x86_sandbox cef_sandbox" in "e:\code\chromium_git\chromium\src"...
ninja: Entering directory `out\Debug_GN_x86_sandbox'
[64/892] CXX obj/base/allocator/partition_allocator/src/partition_alloc/allocator_base/cstring_builder.obj
FAILED: obj/base/allocator/partition_allocator/src/partition_alloc/allocator_base/cstring_builder.obj
..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.exe /c ../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/cstring_builder.cc /Foobj/base/allocator/partition_allocator/src/partition_alloc/allocator_base/cstring_builder.obj /nologo /showIncludes:user "-imsvcC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\include" "-imsvcC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.38.33130\ATLMFC\include" "-imsvcC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\VS\include" "-imsvcC:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt" "-imsvcC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\um" "-imsvcC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\shared" "-imsvcC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\winrt" "-imsvcC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\cppwinrt" -DDCHECK_ALWAYS_ON=1 -DUSE_AURA=1 -D_HAS_NODISCARD -D_CRT_NONSTDC_NO_WARNINGS -D_WINSOCK_DEPRECATED_NO_WARNINGS "-DCR_CLANG_REVISION=\"llvmorg-18-init-9505-g10664813-1\"" -D_HAS_EXCEPTIONS=0 -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=2 -DWIN32 -D_SECURE_ATL -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=NTDDI_WIN10_NI -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -D_HAS_ITERATOR_DEBUGGING=0 -DIS_PARTITION_ALLOC_IMPL -I../.. -Igen -I../../base/allocator/partition_allocator/src -Igen/base/allocator/partition_allocator/src /W4 -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wno-nonportable-include-path -Wenum-compare-conditional -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture -Wno-invalid-offsetof -Wno-vla-extension -Wno-thread-safety-reference-return -Wno-delayed-template-parsing-in-cxx20 -Wshadow /WX -fno-delete-null-pointer-checks -fno-ident -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -mllvm -split-threshold-for-reg-with-hint=0 /clang:-ffp-contract=off -fcomplete-member-pointers /Gy /FS /bigobj /utf-8 /Zc:twoPhase -ffile-reproducible /Zc:sizedDealloc- /D__WRL_ENABLE_FUNCTION_STATICS__ -fmsc-version=1934 -m32 -msse3 /Brepro -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -ffile-compilation-dir=. -no-canonical-prefixes -ftrivial-auto-var-init=pattern /Z7 -gno-codeview-command-line -gcodeview-ghash -Xclang -fuse-ctor-homing /guard:cf,nochecks /MTd -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors /O2 /Ob2 /Oy- /Zc:inline /Gw /clang:-fno-math-errno -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare /std:c++20 -Wno-trigraphs /TP /GR- /Fd"obj/base/allocator/partition_allocator/src/partition_alloc/allocator_base_cc.pdb"
../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/cstring_builder.cc(64,26): error: no member named 'numeric_limits' in namespace 'std'
64 | char buffer[Log10(std::numeric_limits<T>::max()) + 3];
| ~~~~~^
../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/cstring_builder.cc(64,41): error: 'T' does not refer to a value
64 | char buffer[Log10(std::numeric_limits<T>::max()) + 3];
| ^
../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/cstring_builder.cc(58,20): note: declared here
58 | template <typename T>
| ^
../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/cstring_builder.cc(64,45): error: no member named 'max' in the global namespace
64 | char buffer[Log10(std::numeric_limits<T>::max()) + 3];
| ~~^
../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/cstring_builder.cc(162,47): error: no member named 'numeric_limits' in namespace 'std'
162 | PutNormalFloatingPoint(value > 0 ? std::numeric_limits<double>::min()
| ~~~~~^
../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/cstring_builder.cc(162,68): error: expected '(' for function-style cast or type construction
162 | PutNormalFloatingPoint(value > 0 ? std::numeric_limits<double>::min()
| ~~~~~~^
../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/cstring_builder.cc(162,71): error: no member named 'min' in the global namespace
162 | PutNormalFloatingPoint(value > 0 ? std::numeric_limits<double>::min()
| ~~^
../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/cstring_builder.cc(163,48): error: no member named 'numeric_limits' in namespace 'std'
163 | : -std::numeric_limits<double>::min(),
| ~~~~~^
../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/cstring_builder.cc(163,69): error: expected '(' for function-style cast or type construction
163 | : -std::numeric_limits<double>::min(),
| ~~~~~~^
../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/cstring_builder.cc(163,72): error: no member named 'min' in the global namespace
163 | : -std::numeric_limits<double>::min(),
| ~~^
9 errors generated.
[85/892] CXX obj/third_party/abseil-cpp/absl/base/base/cycleclock.obj
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
File "e:\code\automate\automate-git.py", line 1368, in <module>
run(command + build_path + ' cef_sandbox', chromium_src_dir, depot_tools_dir,
File "e:\code\automate\automate-git.py", line 66, in run
return subprocess.check_call(
File "e:\code\depot_tools\bootstrap-2@3_8_10_chromium_26_bin\python3\bin\lib\subprocess.py", line 364, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['ninja', '-C', 'out\\Debug_GN_x86_sandbox', 'cef_sandbox']' returned non-zero exit status 1.

[ndesktop]

See viewtopic.php?f=6&t=19630&p=54460&hilit=limits.h#p54460

[delphirules]

See viewtopic.php?f=6&t=19630&p=54460&hilit=limits.h#p54460

Hum, i thought this issue was fixed on the new build... will do the workaround again, thanks.

[ndesktop]

Maybe we can get a patch in CEF to fix this. Is there an issue for this?
@magreenblatt, should we create an issue for this? (even it looks like a specific chromium-using-vs2022 thing)

[magreenblatt]

Yes, we can patch 6099 branch. It’s already fixed (in Chromium) for 6167 and master.