Allow synchronously sending extra_info to renderer

Made a cool mod to CEF that you'd like to share with others? Discuss CEF modifications here, and view modifications that others have made.

Allow synchronously sending extra_info to renderer

Postby petersmulovics » Wed Feb 14, 2018 11:23 am

Hi,

My team created a PR at https://bitbucket.org/chromiumembedded/cef/pull-requests/147/allow-synchronously-sending-extra_info-to/diff, for which we would like to ask for help to review.

What is the problem it solves? It does allow you to synchronously send extra_info to renderer at each browser creation. As a result, this allows you to solve the problem raised at https://bitbucket.org/chromiumembedded/cef/issues/1088/allow-synchronously-sending-extra_info-to. What does that issue focuses on?

This allows language wrappers to register objects that would be synchronously available at the window creation, e.g. you could register objects for scripting that would work even when the window is navigated between domains (one of the basic usecases this solves is logging in using SSO in those windows - most of the SSO solutions involve a 'dance' to and fro on a SSO domain).

So please, if possible, provide feedback on the PR to make it more feasible to have it merged in the future,

Thank you,
Peter
petersmulovics
Newbie
 
Posts: 1
Joined: Tue Feb 06, 2018 8:41 pm

Re: Allow synchronously sending extra_info to renderer

Postby Czarek » Mon Feb 19, 2018 8:17 am

The reviewing process before PR is accepted can take some time. It usually requires substantial amount of work from the reviewer to make sure code quality is high and it doesn't cause any side issues. You will have to be patient and wait until Marshall finds time. He is the only one that can merge PRs currently.
Maintainer of the CEF Python, PHP Desktop and CEF2go projects. Programmer for hire, see my Resume.
User avatar
Czarek
Genius
 
Posts: 1338
Joined: Sun Nov 06, 2011 2:12 am
Location: Poland


Return to Modifications Forum

Who is online

Users browsing this forum: No registered users and 1 guest